Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 2424433002: [ic] Delete old KeyedLoadIC code (Closed)

Created:
4 years, 2 months ago by Jakob Kummerow
Modified:
4 years, 2 months ago
CC:
v8-reviews_googlegroups.com, ulan
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[ic] Delete old KeyedLoadIC code RIP, handwritten KeyedLoadICStub, handwritten KeyedLoadIC_Megamorphic, and hydrogenized KeyedLoadGeneric! Committed: https://crrev.com/3f6e0a4ef92bf7859f42d20c8ff3e31a2e5acc0f Cr-Commit-Position: refs/heads/master@{#40354}

Patch Set 1 #

Patch Set 2 : undo accidental edit #

Patch Set 3 : fix failing test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -4688 lines) Patch
M src/arm/code-stubs-arm.cc View 2 chunks +0 lines, -77 lines 0 comments Download
M src/arm/macro-assembler-arm.h View 2 chunks +0 lines, -16 lines 0 comments Download
M src/arm/macro-assembler-arm.cc View 2 chunks +0 lines, -93 lines 0 comments Download
M src/arm64/code-stubs-arm64.cc View 2 chunks +0 lines, -76 lines 0 comments Download
M src/arm64/macro-assembler-arm64.h View 2 chunks +0 lines, -25 lines 0 comments Download
M src/arm64/macro-assembler-arm64.cc View 2 chunks +0 lines, -77 lines 0 comments Download
M src/assembler.h View 1 chunk +0 lines, -4 lines 0 comments Download
M src/assembler.cc View 1 chunk +0 lines, -13 lines 0 comments Download
M src/builtins/builtins.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/builtins/builtins-handler.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M src/code-factory.cc View 1 chunk +3 lines, -15 lines 0 comments Download
M src/code-stubs.h View 6 chunks +0 lines, -40 lines 0 comments Download
M src/code-stubs.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M src/code-stubs-hydrogen.cc View 1 chunk +0 lines, -248 lines 0 comments Download
M src/crankshaft/hydrogen.h View 1 chunk +0 lines, -22 lines 0 comments Download
M src/crankshaft/hydrogen.cc View 2 chunks +0 lines, -185 lines 0 comments Download
M src/deoptimize-reason.h View 2 chunks +0 lines, -4 lines 0 comments Download
M src/external-reference-table.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M src/field-index.h View 2 chunks +0 lines, -3 lines 0 comments Download
M src/field-index-inl.h View 1 chunk +0 lines, -20 lines 0 comments Download
M src/flag-definitions.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/heap/heap.cc View 1 2 chunks +0 lines, -6 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 1 chunk +0 lines, -177 lines 0 comments Download
M src/ia32/macro-assembler-ia32.h View 2 chunks +0 lines, -9 lines 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 2 chunks +0 lines, -90 lines 0 comments Download
M src/ic/arm/ic-arm.cc View 3 chunks +0 lines, -244 lines 0 comments Download
M src/ic/arm64/ic-arm64.cc View 3 chunks +0 lines, -271 lines 0 comments Download
M src/ic/ia32/ic-ia32.cc View 2 chunks +0 lines, -244 lines 0 comments Download
M src/ic/ic.h View 1 chunk +0 lines, -4 lines 0 comments Download
M src/ic/ic.cc View 1 chunk +0 lines, -13 lines 0 comments Download
M src/ic/mips/ic-mips.cc View 3 chunks +0 lines, -244 lines 0 comments Download
M src/ic/mips64/ic-mips64.cc View 3 chunks +0 lines, -245 lines 0 comments Download
M src/ic/ppc/ic-ppc.cc View 3 chunks +0 lines, -250 lines 0 comments Download
M src/ic/s390/ic-s390.cc View 3 chunks +0 lines, -242 lines 0 comments Download
M src/ic/x64/ic-x64.cc View 2 chunks +0 lines, -243 lines 0 comments Download
M src/ic/x87/ic-x87.cc View 2 chunks +0 lines, -244 lines 0 comments Download
M src/isolate.h View 3 chunks +0 lines, -6 lines 0 comments Download
M src/isolate.cc View 3 chunks +0 lines, -4 lines 0 comments Download
M src/lookup-cache.h View 1 chunk +0 lines, -59 lines 0 comments Download
M src/lookup-cache.cc View 1 chunk +0 lines, -67 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 2 chunks +0 lines, -77 lines 0 comments Download
M src/mips/macro-assembler-mips.h View 2 chunks +0 lines, -15 lines 0 comments Download
M src/mips/macro-assembler-mips.cc View 2 chunks +0 lines, -95 lines 0 comments Download
M src/mips64/code-stubs-mips64.cc View 2 chunks +0 lines, -79 lines 0 comments Download
M src/mips64/macro-assembler-mips64.h View 2 chunks +0 lines, -15 lines 0 comments Download
M src/mips64/macro-assembler-mips64.cc View 2 chunks +0 lines, -95 lines 0 comments Download
M src/ppc/code-stubs-ppc.cc View 2 chunks +0 lines, -79 lines 0 comments Download
M src/ppc/macro-assembler-ppc.h View 2 chunks +0 lines, -10 lines 0 comments Download
M src/ppc/macro-assembler-ppc.cc View 2 chunks +0 lines, -94 lines 0 comments Download
M src/s390/code-stubs-s390.cc View 2 chunks +0 lines, -72 lines 0 comments Download
M src/s390/macro-assembler-s390.h View 2 chunks +0 lines, -8 lines 0 comments Download
M src/s390/macro-assembler-s390.cc View 2 chunks +0 lines, -91 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 2 chunks +0 lines, -78 lines 0 comments Download
M src/x64/macro-assembler-x64.h View 2 chunks +0 lines, -15 lines 0 comments Download
M src/x64/macro-assembler-x64.cc View 2 chunks +0 lines, -95 lines 0 comments Download
M src/x87/code-stubs-x87.cc View 2 chunks +0 lines, -66 lines 0 comments Download
M src/x87/macro-assembler-x87.h View 2 chunks +0 lines, -9 lines 0 comments Download
M src/x87/macro-assembler-x87.cc View 2 chunks +0 lines, -90 lines 0 comments Download
M test/cctest/test-api.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M test/cctest/test-heap-profiler.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (11 generated)
Jakob Kummerow
Igor: PTAL. Hannes: Please review heap.cc (the keyed_lookup_cache is gone, so clearing it is no ...
4 years, 2 months ago (2016-10-14 17:43:30 UTC) #2
Igor Sheludko
Whoa! That was massive! lgtm!
4 years, 2 months ago (2016-10-14 18:52:01 UTC) #9
Hannes Payer (out of office)
lgtm
4 years, 2 months ago (2016-10-17 09:14:14 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2424433002/40001
4 years, 2 months ago (2016-10-17 09:57:15 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 2 months ago (2016-10-17 10:31:12 UTC) #15
commit-bot: I haz the power
4 years, 2 months ago (2016-10-17 10:31:23 UTC) #17
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/3f6e0a4ef92bf7859f42d20c8ff3e31a2e5acc0f
Cr-Commit-Position: refs/heads/master@{#40354}

Powered by Google App Engine
This is Rietveld 408576698