chrome/browser/ui/cocoa/website_settings/permission_selector_button.h - Issue 242443005: Changes cocoa implementation of permission bubble to better match mocks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/website_settings/permission_selector_button.h

Issue 242443005: Changes cocoa implementation of permission bubble to better match mocks. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/cocoa/website_settings/permission_bubble_controller_unittest.mm ('K') | « chrome/browser/ui/cocoa/website_settings/permission_bubble_controller_unittest.mm ('k') | chrome/browser/ui/cocoa/website_settings/permission_selector_button.mm » ('j') | chrome/browser/ui/cocoa/website_settings/permission_selector_button.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/website_settings/permission_selector_button.h

diff --git a/chrome/browser/ui/cocoa/website_settings/permission_selector_button.h b/chrome/browser/ui/cocoa/website_settings/permission_selector_button.h

index a28519959259bfb2c6bc42a1085fee4223cacbf7..ad94c5b95e75dc76a9531eaac3441c0d246742a3 100644

--- a/chrome/browser/ui/cocoa/website_settings/permission_selector_button.h

+++ b/chrome/browser/ui/cocoa/website_settings/permission_selector_button.h

@@ -26,8 +26,8 @@

forURL:(const GURL&)url

withCallback:(PermissionMenuModel::ChangeCallback)callback;

-// Returns the size of the button with the given title.

-- (NSSize)sizeForTitle:(NSString*)title;

+// Returns the best size for |button| with the given title.

++ (NSSize)sizeForTitle:(NSString*)title forButton:(NSButton*)button;

// Returns the largest possible size given all of the items in the menu.

- (CGFloat)maxTitleWidthWithDefaultSetting:(ContentSetting)defaultSetting;