Changes cocoa implementation of permission bubble to better match mocks.

chrome/browser/ui/cocoa/website_settings/permission_bubble_controller_unittest.mm

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.h"
 
 #include "base/mac/foundation_util.h"
 #include "base/stl_util.h"
 #include "base/strings/sys_string_conversions.h"
 #include "base/strings/utf_string_conversions.h"
@@ skipping 55 matching lines @@
 
   void AddRequest(const std::string& title) {
     MockPermissionBubbleRequest* request = new MockPermissionBubbleRequest(
         title,
         l10n_util::GetStringUTF8(IDS_PERMISSION_ALLOW),
         l10n_util::GetStringUTF8(IDS_PERMISSION_DENY));
     requests_.push_back(request);
   }
 
   NSButton* FindButtonWithTitle(const std::string& title) {
-    return FindButtonWithTitle(base::SysUTF8ToNSString(title));
+    return FindButtonWithTitle(base::SysUTF8ToNSString(title), false);
   }
 
   NSButton* FindButtonWithTitle(int title_id) {
-    return FindButtonWithTitle(l10n_util::GetNSString(title_id));
+    return FindButtonWithTitle(l10n_util::GetNSString(title_id), false);
   }
 
-  NSButton* FindButtonWithTitle(NSString* title) {
+  NSButton* FindMenuButtonWithTitle(int title_id) {
+    return FindButtonWithTitle(l10n_util::GetNSString(title_id), true);
+  }
+
+  // IDS_PERMISSION_ALLOW and IDS_PERMISSION_DENY are used for two distinct
+  // UI elements, both of which derive from NSButton.  In order to test for
+  // each kind of element, check the derived class of one - NSPopUpButton -
+  // to distinguish between the two.
+  NSButton* FindButtonWithTitle(NSString* title, bool want_nspopup) {
     NSView* parent = base::mac::ObjCCastStrict<NSView>([controller_ bubble]);

[groby-ooo-7-16, 2014/04/18 18:18:18]

No need to cast - the bubble is always an NSView

[leng, 2014/04/18 22:48:46]

Made NSButton to avoid a cast.

     for (NSView* child in [parent subviews]) {
       NSButton* button = base::mac::ObjCCast<NSButton>(child);

[groby-ooo-7-16, 2014/04/18 18:18:18]

Shorter & less casts:

Class button_class = want_nspopup ? [NSPopUpButton class] : [NSButtonClass]
for (NSButton* button in [parent subviews]) {
  if (![button isMemberOfClass:button_class])
    continue;
  if ([title isEqualToString:[button title])
    return button;
}

isMemberOfClass restricts to specific classes - subclass instances are false.

[leng, 2014/04/18 22:48:46]

I like it.  I need to use ConstrainedWindowButton as the non-NSPopUpButton,
because none of these are straight NSButtons.

       if ([title isEqualToString:[button title]]) {
-        return button;
+        NSPopUpButton* popup = base::mac::ObjCCast<NSPopUpButton>(button);
+        if ((!want_nspopup && !popup) || (want_nspopup && popup))
+          return button;
       }
     }
     return nil;
   }
 
   NSTextField* FindTextFieldWithString(const std::string& text) {
     NSView* parent = base::mac::ObjCCastStrict<NSView>([controller_ bubble]);
     return FindTextFieldWithString(parent, base::SysUTF8ToNSString(text));
   }
 
   NSTextField* FindTextFieldWithString(NSView* view, NSString* text) {
     NSTextField* textField = nil;
     for (NSView* child in [view subviews]) {
       textField = base::mac::ObjCCast<NSTextField>(child);
       if (![[textField stringValue] hasSuffix:text]) {
         textField = FindTextFieldWithString(child, text);
         if (textField)
           break;
       }
     }
     return textField;
   }
 
+  void ChangePermissionMenuSelection(NSButton* menu_button, int next_title_id) {
+    NSMenu* menu = [base::mac::ObjCCast<NSPopUpButton>(menu_button) menu];

[groby-ooo-7-16, 2014/04/18 18:18:18]

I think you want strict here, or even pass in an NSPopUpButton - this does not
make sense for other buttons?

[leng, 2014/04/18 22:48:46]

Done.

+    NSString* next_title = l10n_util::GetNSString(next_title_id);
+    EXPECT_EQ([[menu itemWithTitle:[menu_button title]] state], NSOnState);
+    NSMenuItem* next_item = [menu itemWithTitle:next_title];
+    EXPECT_EQ([next_item state], NSOffState);
+    [menu performActionForItemAtIndex:[menu indexOfItem:next_item]];
+  }
+
   NSMenuItem* FindCustomizeMenuItem() {
     NSButton* button = FindButtonWithTitle(IDS_PERMISSION_DENY);
     if (!button || ![button isKindOfClass:[SplitBlockButton class]])
       return nil;
     NSString* customize = l10n_util::GetNSString(IDS_PERMISSION_CUSTOMIZE);
     SplitBlockButton* block_button =
         base::mac::ObjCCast<SplitBlockButton>(button);
     for (NSMenuItem* item in [[block_button menu] itemArray]) {
       if ([[item title] isEqualToString:customize])
         return item;
@@ skipping 41 matching lines @@
   EXPECT_TRUE(FindTextFieldWithString(kPermissionA));
   EXPECT_TRUE(FindTextFieldWithString(kPermissionB));
   EXPECT_TRUE(FindTextFieldWithString(kPermissionC));
 
   EXPECT_TRUE(FindButtonWithTitle(IDS_PERMISSION_ALLOW));
   EXPECT_TRUE(FindButtonWithTitle(IDS_PERMISSION_DENY));
   EXPECT_TRUE(FindCustomizeMenuItem());
   EXPECT_FALSE(FindButtonWithTitle(IDS_OK));
 }
 
-TEST_F(PermissionBubbleControllerTest, ShowCustomizationMode) {
-  AddRequest(kPermissionB);
-
+TEST_F(PermissionBubbleControllerTest, ShowCustomizationModeAllow) {
   accept_states_.push_back(true);
-  accept_states_.push_back(false);
-
   [controller_ showAtAnchor:NSZeroPoint
               withDelegate:this
                forRequests:requests_
               acceptStates:accept_states_
          customizationMode:YES];
 
-  // Test that each checkbox is visible and only the first is checked.
-  NSButton* checkbox_a = FindButtonWithTitle(kPermissionA);
-  NSButton* checkbox_b = FindButtonWithTitle(kPermissionB);
-  EXPECT_TRUE(checkbox_a);
-  EXPECT_TRUE(checkbox_b);
-  EXPECT_EQ(NSOnState, [checkbox_a state]);
-  EXPECT_EQ(NSOffState, [checkbox_b state]);
+  // Test that there is one menu, with 'Allow' visible.
+  EXPECT_TRUE(FindMenuButtonWithTitle(IDS_PERMISSION_ALLOW));
+  EXPECT_FALSE(FindMenuButtonWithTitle(IDS_PERMISSION_DENY));
 
   EXPECT_TRUE(FindButtonWithTitle(IDS_OK));
   EXPECT_FALSE(FindButtonWithTitle(IDS_PERMISSION_ALLOW));
+  EXPECT_FALSE(FindButtonWithTitle(IDS_PERMISSION_DENY));
+  EXPECT_FALSE(FindCustomizeMenuItem());
+}
+
+TEST_F(PermissionBubbleControllerTest, ShowCustomizationModeBlock) {
+  accept_states_.push_back(false);
+  [controller_ showAtAnchor:NSZeroPoint
+              withDelegate:this
+               forRequests:requests_
+              acceptStates:accept_states_
+         customizationMode:YES];
+
+  // Test that there is one menu, with 'Block' visible.
+  EXPECT_TRUE(FindMenuButtonWithTitle(IDS_PERMISSION_DENY));
+  EXPECT_FALSE(FindMenuButtonWithTitle(IDS_PERMISSION_ALLOW));
+
+  EXPECT_TRUE(FindButtonWithTitle(IDS_OK));
+  EXPECT_FALSE(FindButtonWithTitle(IDS_PERMISSION_ALLOW));
   EXPECT_FALSE(FindButtonWithTitle(IDS_PERMISSION_DENY));
   EXPECT_FALSE(FindCustomizeMenuItem());
 }
 
 TEST_F(PermissionBubbleControllerTest, OK) {
   accept_states_.push_back(true);
   [controller_ showAtAnchor:NSZeroPoint
               withDelegate:this
                forRequests:requests_
               acceptStates:accept_states_
@@ skipping 18 matching lines @@
   [controller_ showAtAnchor:NSZeroPoint
               withDelegate:this
                forRequests:requests_
               acceptStates:accept_states_
          customizationMode:NO];
 
   EXPECT_CALL(*this, Deny()).Times(1);
   [FindButtonWithTitle(IDS_PERMISSION_DENY) performClick:nil];
 }
 
-TEST_F(PermissionBubbleControllerTest, ToggleCheckbox) {
+TEST_F(PermissionBubbleControllerTest, ChangePermissionSelection) {
   AddRequest(kPermissionB);
 
   accept_states_.push_back(true);
   accept_states_.push_back(false);
 
   [controller_ showAtAnchor:NSZeroPoint
               withDelegate:this
                forRequests:requests_
               acceptStates:accept_states_
          customizationMode:YES];
 
   EXPECT_CALL(*this, ToggleAccept(0, false)).Times(1);
   EXPECT_CALL(*this, ToggleAccept(1, true)).Times(1);
-  [FindButtonWithTitle(kPermissionA) performClick:nil];
-  [FindButtonWithTitle(kPermissionB) performClick:nil];
+  NSButton* menu_a = FindMenuButtonWithTitle(IDS_PERMISSION_ALLOW);
+  NSButton* menu_b = FindMenuButtonWithTitle(IDS_PERMISSION_DENY);
+  ChangePermissionMenuSelection(menu_a, IDS_PERMISSION_DENY);
+  ChangePermissionMenuSelection(menu_b, IDS_PERMISSION_ALLOW);
 }
 
 TEST_F(PermissionBubbleControllerTest, ClickCustomize) {
   AddRequest(kPermissionB);
   [controller_ showAtAnchor:NSZeroPoint
               withDelegate:this
                forRequests:requests_
               acceptStates:accept_states_
          customizationMode:NO];
 
   EXPECT_CALL(*this, SetCustomizationMode()).Times(1);
   NSMenuItem* customize_item = FindCustomizeMenuItem();
   EXPECT_TRUE(customize_item);
   NSMenu* menu = [customize_item menu];
   [menu performActionForItemAtIndex:[menu indexOfItem:customize_item]];
 }