Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(357)

Issue 2424313004: [inspector] conditionally copy files for inspector test. (Closed)

Created:
4 years, 2 months ago by Yang
Modified:
4 years, 1 month ago
Reviewers:
Michael Achenbach
CC:
v8-reviews_googlegroups.com, devtools-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[inspector] conditionally copy files for inspector test. R=machenbach@chromium.org Committed: https://crrev.com/8971b6b6c36ca6434809a2987548d2a66c9d404b Cr-Commit-Position: refs/heads/master@{#40528}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -13 lines) Patch
M test/inspector/inspector.isolate View 1 chunk +9 lines, -13 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Yang
4 years, 2 months ago (2016-10-18 12:11:57 UTC) #1
Michael Achenbach
lgtm - wait with landing until https://codereview.chromium.org/2431653002/ can land
4 years, 2 months ago (2016-10-18 13:39:24 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2424313004/1
4 years, 1 month ago (2016-10-24 10:30:59 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-24 10:57:14 UTC) #5
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:10:53 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8971b6b6c36ca6434809a2987548d2a66c9d404b
Cr-Commit-Position: refs/heads/master@{#40528}

Powered by Google App Engine
This is Rietveld 408576698