Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8154)

Unified Diff: chrome/renderer/extensions/dispatcher.cc

Issue 24243007: Allow webview API in an unblessed extension process (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebased and comments added Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/extensions/dispatcher.cc
diff --git a/chrome/renderer/extensions/dispatcher.cc b/chrome/renderer/extensions/dispatcher.cc
index 9ea73e6c3a2d0d1cf6de8701e2562993e72e90c8..a911d8f43c85f3549841e7083176a0dfe07f1ede 100644
--- a/chrome/renderer/extensions/dispatcher.cc
+++ b/chrome/renderer/extensions/dispatcher.cc
@@ -1113,7 +1113,16 @@ void Dispatcher::DidCreateScriptContext(
module_system->Require("windowControls");
}
- if (context_type == Feature::BLESSED_EXTENSION_CONTEXT) {
+ // Currently only platform apps and whitelisted component extensions support
+ // the <webview> tag, because the "denyWebView" module will affect the
+ // performance of DOM modifications (http://crbug.com/196453).
+ // We used to limit WebView to |BLESSED_EXTENSION_CONTEXT| within platform
+ // apps. An ext/app runs in a blessed extension context, if it is the active
+ // extension in the current process, in other words, if it is loaded in the
not at google - send to devlin 2013/09/25 17:14:03 FWIW the comment is slightly misleading since ther
guohui 2013/09/25 22:43:51 Done.
+ // top frame. To support webview in an iframed extension, we have to allow
not at google - send to devlin 2013/09/25 17:14:03 note that this would include other non toplevel fr
guohui 2013/09/25 22:43:51 Done.
+ // unblessed extension context as well.
+ if (context_type == Feature::BLESSED_EXTENSION_CONTEXT ||
+ context_type == Feature::UNBLESSED_EXTENSION_CONTEXT) {
// Note: setting up the WebView class here, not the chrome.webview API.
// The API will be automatically set up when first used.
if (extension->HasAPIPermission(APIPermission::kWebView)) {

Powered by Google App Engine
This is Rietveld 408576698