Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Issue 24243005: Use Unique<Map> in CompareMap. (Closed)

Created:
7 years, 3 months ago by titzer
Modified:
7 years, 3 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Visibility:
Public.

Description

Use Unique<Map> in CompareMap. BUG= R=verwaest@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=16843

Patch Set 1 #

Patch Set 2 : Simplify Unique tests and disallow allocation during creation of unique in tests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -114 lines) Patch
M src/arm/lithium-arm.h View 1 chunk +1 line, -1 line 0 comments Download
M src/hydrogen-instructions.h View 2 chunks +4 lines, -3 lines 0 comments Download
M src/hydrogen-instructions.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/lithium-ia32.h View 1 chunk +1 line, -1 line 0 comments Download
M src/mips/lithium-mips.h View 1 chunk +1 line, -1 line 0 comments Download
M src/unique.h View 4 chunks +12 lines, -4 lines 0 comments Download
M src/x64/lithium-x64.h View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-unique.cc View 1 15 chunks +55 lines, -102 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
titzer
Now you get your asserts!
7 years, 3 months ago (2013-09-19 12:27:36 UTC) #1
Toon Verwaest
lgtm
7 years, 3 months ago (2013-09-19 13:15:03 UTC) #2
titzer
On 2013/09/19 13:15:03, Toon Verwaest wrote: > lgtm Had to hack the tests to deal ...
7 years, 3 months ago (2013-09-19 15:33:45 UTC) #3
Toon Verwaest
weird semicolon placement. LGTM :)
7 years, 3 months ago (2013-09-19 16:49:44 UTC) #4
titzer
7 years, 3 months ago (2013-09-19 17:03:10 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r16843 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698