Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Unified Diff: components/data_reduction_proxy/core/common/data_reduction_proxy_headers.h

Issue 2424263002: Added support for heavy page previews transformations (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/data_reduction_proxy/core/common/data_reduction_proxy_headers.h
diff --git a/components/data_reduction_proxy/core/common/data_reduction_proxy_headers.h b/components/data_reduction_proxy/core/common/data_reduction_proxy_headers.h
index b0ea201384ef6f926c3137ebf57335ae616b3c6b..8074f9d59813a8300c96d8fc250c41fdb9577a61 100644
--- a/components/data_reduction_proxy/core/common/data_reduction_proxy_headers.h
+++ b/components/data_reduction_proxy/core/common/data_reduction_proxy_headers.h
@@ -101,6 +101,11 @@ const char* chrome_proxy_lite_page_directive();
// preview experiment to ignore the blacklist.
const char* chrome_proxy_lite_page_ignore_blacklist_directive();
+// Requests a transformation only if the server determines that the page is
RyanSturm 2016/10/19 18:58:57 nit:s/page/resource/ ?
bengr 2016/10/19 23:34:28 Nope, the server looks at the enclosing page. Easy
RyanSturm 2016/10/19 23:43:12 Weird. sgtm.
+// otherwise heavy (requires the network transfer of a lot of bytes). Added
RyanSturm 2016/10/19 18:58:56 nit: s/(requires the network transfer/ (i.e., the
bengr 2016/10/19 23:34:28 Done.
+// to a previews directive. E.g., "lite-page;if-heavy".
+const char* if_heavy_qualifier();
+
// Returns true if the Chrome-Proxy-Content-Transform response header indicates
// that an empty image has been provided.
bool IsEmptyImagePreview(const net::HttpResponseHeaders& headers);

Powered by Google App Engine
This is Rietveld 408576698