Half float neon port, enable O2 for neon, and denormal test.

Half float neon port, enable O2 for neon, and denormal test.

HalfFloatPlane unittest for denormal half floats

Halffloats have a limited range.  It shouldnt normally come up, but if the scale value passed in produces a small value, the half floats will be denormals, which are slow and/or flust to zero.  This test ensures they behave the same in C and SIMD and tests the performance of denormals.


TEST=TestHalfFloatPlane_denormal
BUG=libyuv:560
R=hubbe@chromium.org

Committed: https://chromium.googlesource.com/libyuv/libyuv/+/f553db2d30c7c5686a7b41481f6fe96a876c7a6c

[fbarchard1, 2016-10-18 22:04:30]

Description was changed from

==========
unittest for denormal half floats

BUG=None
==========

to

==========
HalfFloatPlane unittest for denormal half floats

Halffloats have a limited range.  It shouldnt normally come up, but if the scale
value passed in produces a small value, the half floats will be denormals, which
are slow and/or flust to zero.  This test ensures they behave the same in C and
SIMD and tests the performance of denormals.

TEST=TestHalfFloatPlane_denormal
BUG=libyuv:560
==========

[fbarchard1, 2016-10-18 22:04:30]

fbarchard@google.com changed reviewers:
+ hubbe@chromium.org

[fbarchard1, 2016-10-18 22:05:31]

out/Release/libyuv_unittest --gtest_filter=*Half* --libyuv_width=1280
--libyuv_height=720 --libyuv_repeat=999 --libyuv_flags=-1 --libyuv_cpu_info=-1

In Z620 with IvyBridge
[ RUN      ] LibYUVPlanarTest.TestHalfFloatPlane
[       OK ] LibYUVPlanarTest.TestHalfFloatPlane (472 ms)
[ RUN      ] LibYUVPlanarTest.TestHalfFloatPlane_denormal
[       OK ] LibYUVPlanarTest.TestHalfFloatPlane_denormal (20612 ms)

[hubbe, 2016-10-18 22:40:43]

lgtm

https://codereview.chromium.org/2424233004/diff/1/unit_test/planar_test.cc
File unit_test/planar_test.cc (right):

https://codereview.chromium.org/2424233004/diff/1/unit_test/planar_test.cc#ne...
unit_test/planar_test.cc:2126: // happen sicne scale is 1/(1<<bits) where bits
is 9, 10 or 12.
s/sicne/since/

Also, some people at intel are working on code where bits = 16

[fbarchard1, 2016-10-19 02:03:31]

ptal - did Neon 64 bit version.

[hubbe, 2016-10-19 21:16:52]

LGTM (not qualified to properly review the neon code though)
Please update the CL description.

[fbarchard1, 2016-10-20 01:13:03]

Description was changed from

==========
HalfFloatPlane unittest for denormal half floats

Halffloats have a limited range.  It shouldnt normally come up, but if the scale
value passed in produces a small value, the half floats will be denormals, which
are slow and/or flust to zero.  This test ensures they behave the same in C and
SIMD and tests the performance of denormals.

TEST=TestHalfFloatPlane_denormal
BUG=libyuv:560
==========

to

==========
HalfFloatPlane unittest for denormal half floats

Halffloats have a limited range.  It shouldnt normally come up, but if the scale
value passed in produces a small value, the half floats will be denormals, which
are slow and/or flust to zero.  This test ensures they behave the same in C and
SIMD and tests the performance of denormals.

TEST=TestHalfFloatPlane_denormal
BUG=libyuv:560
R=hubbe@chromium.org

Committed:
https://chromium.googlesource.com/libyuv/libyuv/+/f553db2d30c7c5686a7b41481f6...
==========

[fbarchard1, 2016-10-20 01:13:04]

Committed patchset #4 (id:60001) manually as
f553db2d30c7c5686a7b41481f6fe96a876c7a6c (presubmit successful).

[fbarchard1, 2016-10-20 01:29:22]

Description was changed from

==========
HalfFloatPlane unittest for denormal half floats

Halffloats have a limited range.  It shouldnt normally come up, but if the scale
value passed in produces a small value, the half floats will be denormals, which
are slow and/or flust to zero.  This test ensures they behave the same in C and
SIMD and tests the performance of denormals.

TEST=TestHalfFloatPlane_denormal
BUG=libyuv:560
R=hubbe@chromium.org

Committed:
https://chromium.googlesource.com/libyuv/libyuv/+/f553db2d30c7c5686a7b41481f6...
==========

to

==========
Half float neon port, enable O2 for neon, and denormal test.

HalfFloatPlane unittest for denormal half floats

Halffloats have a limited range.  It shouldnt normally come up, but if the scale
value passed in produces a small value, the half floats will be denormals, which
are slow and/or flust to zero.  This test ensures they behave the same in C and
SIMD and tests the performance of denormals.


TEST=TestHalfFloatPlane_denormal
BUG=libyuv:560
R=hubbe@chromium.org

Committed:
https://chromium.googlesource.com/libyuv/libyuv/+/f553db2d30c7c5686a7b41481f6...
==========