Media Galleries: Refactor test to not need RunSecondPhase().

chrome/test/data/extensions/api_test/media_galleries/access_attached/test.js

Index: chrome/test/data/extensions/api_test/media_galleries/access_attached/test.js
===================================================================
--- chrome/test/data/extensions/api_test/media_galleries/access_attached/test.js	(revision 224775)
+++ chrome/test/data/extensions/api_test/media_galleries/access_attached/test.js	(working copy)
@@ -6,29 +6,36 @@
 
 var galleries;
 var testResults = [];
+var expectedFileSystems;
+var testGalleryName;
 
-function testGalleries(expectedFileSystems, testGalleryName) {
-  chrome.test.assertEq(expectedFileSystems, galleries.length);
-
-  for (var i = 0; i < galleries.length; i++) {
-    var metadata = mediaGalleries.getMediaFileSystemMetadata(galleries[i]);
-    if (metadata.name == testGalleryName) {
-      chrome.test.succeed();
-      return;
-    } else {
-      testResults.push(metadata.name);
-    }
-  }
-  chrome.test.fail(testResults + ' vs ' + testGalleryName);
-};
-
 var mediaFileSystemsListCallback = function(results) {
   galleries = results;
 };
 
-chrome.test.runTests([
-  function mediaGalleriesAccessAttached() {
-    mediaGalleries.getMediaFileSystems(
-        chrome.test.callbackPass(mediaFileSystemsListCallback));
-  },
-]);
+chrome.test.getConfig(function(config) {

[tommycli, 2013/09/24 00:34:08]

This getConfig does blow my mind, but looking at other tests, this new style
does seem to be pretty standard.

+  customArg = JSON.parse(config.customArg);
+  expectedFileSystems = customArg[0];
+  testGalleryName = customArg[1];
+
+  chrome.test.runTests([
+    function mediaGalleriesAccessAttached() {
+      mediaGalleries.getMediaFileSystems(
+          chrome.test.callbackPass(mediaFileSystemsListCallback));
+    },
+    function testGalleries() {
+      chrome.test.assertEq(expectedFileSystems, galleries.length);
+
+      for (var i = 0; i < galleries.length; i++) {
+        var metadata = mediaGalleries.getMediaFileSystemMetadata(galleries[i]);
+        if (metadata.name == testGalleryName) {
+          chrome.test.succeed();
+          return;
+        } else {
+          testResults.push(metadata.name);
+        }
+      }
+      chrome.test.fail(testResults + ' vs ' + testGalleryName);
+    },
+  ]);
+})