Media Galleries: Refactor test to not need RunSecondPhase().

Media Galleries: Refactor test to not need RunSecondPhase().

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=225366

[tommycli, 2013-09-24 00:34:08]

https://codereview.chromium.org/24242010/diff/1/chrome/browser/extensions/api...
File chrome/browser/extensions/api/media_galleries/media_galleries_apitest.cc
(right):

https://codereview.chromium.org/24242010/diff/1/chrome/browser/extensions/api...
chrome/browser/extensions/api/media_galleries/media_galleries_apitest.cc:82:
bool RunMediaGalleriesTestWithArg(const std::string& extension_name,
Since everywhere you use this, you are effectively converting from a
base::ListValue, this method could just take a const base::ListValue&. Save you
some SLOC

https://codereview.chromium.org/24242010/diff/1/chrome/test/data/extensions/a...
File
chrome/test/data/extensions/api_test/media_galleries/access_attached/test.js
(right):

https://codereview.chromium.org/24242010/diff/1/chrome/test/data/extensions/a...
chrome/test/data/extensions/api_test/media_galleries/access_attached/test.js:16:
chrome.test.getConfig(function(config) {
This getConfig does blow my mind, but looking at other tests, this new style
does seem to be pretty standard.

[Lei Zhang, 2013-09-24 01:37:45]

https://codereview.chromium.org/24242010/diff/1/chrome/browser/extensions/api...
File chrome/browser/extensions/api/media_galleries/media_galleries_apitest.cc
(right):

https://codereview.chromium.org/24242010/diff/1/chrome/browser/extensions/api...
chrome/browser/extensions/api/media_galleries/media_galleries_apitest.cc:82:
bool RunMediaGalleriesTestWithArg(const std::string& extension_name,
On 2013/09/24 00:34:08, tommycli wrote:
> Since everywhere you use this, you are effectively converting from a
> base::ListValue, this method could just take a const base::ListValue&. Save
you
> some SLOC

Done.

I made RunMediaGalleriesTest() and RunMediaGalleriesTestWithArgs() mirror
RunPlatformAppTest() and RunPlatformAppTestWithArg(), but I suppose we wouldn't
use it any other way in this file.

[tommycli, 2013-09-24 16:30:21]

lgtm

[commit-bot: I haz the power, 2013-09-24 18:25:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thestig@chromium.org/24242010/6001

[commit-bot: I haz the power, 2013-09-24 21:16:37]

Retried try job too often on linux_chromeos for step(s) content_browsertests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

[commit-bot: I haz the power, 2013-09-24 22:16:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thestig@chromium.org/24242010/6001

[commit-bot: I haz the power, 2013-09-25 03:47:43]

Retried try job too often on linux_chromeos for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

[commit-bot: I haz the power, 2013-09-25 19:34:40]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thestig@chromium.org/24242010/6001

[commit-bot: I haz the power, 2013-09-25 21:37:11]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thestig@chromium.org/24242010/6001

[commit-bot: I haz the power, 2013-09-26 06:47:39]

Change committed as 225366