Factor out authorization from AudioRendererHost.

content/browser/renderer_host/media/audio_output_authorization_handler.cc

+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "content/browser/renderer_host/media/audio_output_authorization_handler.h"
+
+#include "base/task_runner_util.h"
+#include "content/browser/bad_message.h"
+#include "content/browser/renderer_host/media/audio_input_device_manager.h"
+#include "content/public/browser/browser_thread.h"
+#include "content/public/browser/media_device_id.h"
+#include "media/base/limits.h"
+
+namespace {
+
+media::AudioParameters MaybeFixAudioParameters(
+    const media::AudioParameters& params) {
+  media::AudioParameters params_copy(params);
+
+  // If the number of output channels is greater than the maximum, use the
+  // maximum allowed value. Hardware channels are ignored upstream, so it is
+  // better to report a valid value if this is the only problem.
+  if (params.channels() > media::limits::kMaxChannels) {
+    DCHECK(params.channel_layout() == media::CHANNEL_LAYOUT_DISCRETE);
+    params_copy.set_channels_for_discrete(media::limits::kMaxChannels);
+  }
+
+  // If hardware parameters are still invalid, use dummy parameters with
+  // fake audio path and let the client handle the error.
+  return params_copy.IsValid()
+             ? params_copy
+             : media::AudioParameters::UnavailableDeviceParams();
+}
+
+media::AudioParameters GetDeviceParametersOnDeviceThread(
+    const std::string& unique_id) {
+  media::AudioManager* audio_manager = media::AudioManager::Get();
+  DCHECK(audio_manager->GetTaskRunner()->BelongsToCurrentThread());
+
+  return media::AudioDeviceDescription::IsDefaultDevice(unique_id)
+             ? audio_manager->GetDefaultOutputStreamParameters()
+             : audio_manager->GetOutputStreamParameters(unique_id);
+}
+
+}  // namespace
+
+namespace content {
+
+AudioOutputAuthorizationHandler::AudioOutputAuthorizationHandler(
+    MediaStreamManager* media_stream_manager,
+    int render_process_id,
+    const std::string& salt)
+    : media_stream_manager_(media_stream_manager),
+      permission_checker_(new MediaDevicesPermissionChecker()),
+      render_process_id_(render_process_id),
+      salt_(salt),
+      weak_factory_(this) {
+  DCHECK(media_stream_manager_);
+}
+
+void AudioOutputAuthorizationHandler::OverridePermissionsForTesting(
+    bool override_value) {
+  DCHECK_CURRENTLY_ON(BrowserThread::IO);
+  DCHECK(permission_checker_);
+  permission_checker_.reset(new MediaDevicesPermissionChecker(override_value));
+}
+
+AudioOutputAuthorizationHandler::~AudioOutputAuthorizationHandler() {
+  // weak_factory is not thread safe. Make sure it's destructed on the
+  // right thread.
+  DCHECK_CURRENTLY_ON(BrowserThread::IO);
+}
+
+void AudioOutputAuthorizationHandler::RequestDeviceAuthorization(
+    int render_frame_id,
+    int session_id,
+    const std::string& device_id,
+    const url::Origin& security_origin,
+    AuthorizationCompletedCallback cb) const {
+  DCHECK_CURRENTLY_ON(BrowserThread::IO);
+
+  if (!IsValidDeviceId(device_id)) {
+    bad_message::ReceivedBadMessage(render_process_id_,
+                                    bad_message::AOAH_NONSENSE_DEVICE_ID);
+    return;
+  }
+
+  // If |session_id| should be used for output device selection and such
+  // output

[o1ka, 2016/11/14 13:24:04]

nit: comment formating

[Max Morin, 2016/11/16 08:49:49]

Done.

+  // device is found, reuse the input device permissions.
+  if (media::AudioDeviceDescription::UseSessionIdToSelectDevice(session_id,
+                                                                device_id)) {
+    const StreamDeviceInfo* info =
+        media_stream_manager_->audio_input_device_manager()
+            ->GetOpenedDeviceInfoById(session_id);
+    if (info && !info->device.matched_output_device_id.empty()) {
+      media::AudioParameters output_params(
+          media::AudioParameters::AUDIO_PCM_LOW_LATENCY,
+          static_cast<media::ChannelLayout>(
+              info->device.matched_output.channel_layout),
+          info->device.matched_output.sample_rate, 16,
+          info->device.matched_output.frames_per_buffer);
+      output_params.set_effects(info->device.matched_output.effects);
+
+      DeviceParametersReceived(
+          std::move(cb), info->device.matched_output_device_id, output_params);
+      return;
+    } else {
+      LOG(WARNING) << "session id used for device selection "

[o1ka, 2016/11/14 13:24:04]

add a comment that the output will go to the default device?

[Max Morin, 2016/11/16 08:49:49]

Done.

+                   << "but no device info found";
+    }
+  }
+
+  // Check security origin if nondefault device is requested.
+  // Ignore check for default device, which is always authorized.
+  if (!media::AudioDeviceDescription::IsDefaultDevice(device_id) &&
+      !MediaStreamManager::IsOriginAllowed(render_process_id_,
+                                           security_origin)) {
+    bad_message::ReceivedBadMessage(render_process_id_,
+                                    bad_message::AOAH_UNAUTHORIZED_URL);
+    return;
+  }
+
+  if (media::AudioDeviceDescription::IsDefaultDevice(device_id)) {

[o1ka, 2016/11/14 13:24:04]

first check for default device and return after AccessChecked(), and then l.116
and than l.129?

[Max Morin, 2016/11/16 08:49:49]

Done.

+    AccessChecked(std::move(cb), device_id, security_origin, true);
+  } else {
+    // Check that MediaStream device permissions have been granted for
+    // nondefault devices.
+    permission_checker_->CheckPermission(
+        MEDIA_DEVICE_TYPE_AUDIO_OUTPUT, render_process_id_, render_frame_id,
+        security_origin,
+        base::Bind(&AudioOutputAuthorizationHandler::AccessChecked,
+                   weak_factory_.GetWeakPtr(), std::move(cb), device_id,
+                   security_origin));
+  }
+}
+
+void AudioOutputAuthorizationHandler::AccessChecked(
+    AuthorizationCompletedCallback cb,
+    const std::string& device_id,
+    const url::Origin& security_origin,
+    bool have_access) const {

[o1ka, 2016/11/14 13:24:04]

has_access?

[Max Morin, 2016/11/16 08:49:49]

Done.

+  DCHECK_CURRENTLY_ON(BrowserThread::IO);
+
+  if (!have_access) {
+    cb.Run(media::OUTPUT_DEVICE_STATUS_ERROR_NOT_AUTHORIZED,
+           media::AudioParameters::UnavailableDeviceParams(), std::string());
+    return;
+  }
+
+  // For default device, read output parameters directly. Nondefault
+  // devices require translation first.
+  if (media::AudioDeviceDescription::IsDefaultDevice(device_id)) {
+    base::PostTaskAndReplyWithResult(
+        media::AudioManager::Get()->GetTaskRunner(), FROM_HERE,
+        base::Bind(&GetDeviceParametersOnDeviceThread,
+                   media::AudioDeviceDescription::kDefaultDeviceId),
+        base::Bind(&AudioOutputAuthorizationHandler::DeviceParametersReceived,
+                   weak_factory_.GetWeakPtr(), std::move(cb),
+                   media::AudioDeviceDescription::kDefaultDeviceId));
+  } else {
+    MediaDevicesManager::BoolDeviceTypes devices_to_enumerate;
+    devices_to_enumerate[MEDIA_DEVICE_TYPE_AUDIO_OUTPUT] = true;
+    media_stream_manager_->media_devices_manager()->EnumerateDevices(
+        devices_to_enumerate,
+        base::Bind(&AudioOutputAuthorizationHandler::TranslateDeviceID,
+                   weak_factory_.GetWeakPtr(), std::move(cb), device_id,
+                   security_origin));
+  }
+}
+
+void AudioOutputAuthorizationHandler::TranslateDeviceID(
+    AuthorizationCompletedCallback cb,
+    const std::string& device_id,
+    const url::Origin& security_origin,
+    const MediaDeviceEnumeration& enumeration) const {
+  DCHECK_CURRENTLY_ON(BrowserThread::IO);
+  DCHECK(!media::AudioDeviceDescription::IsDefaultDevice(device_id));
+  for (const MediaDeviceInfo& device_info :
+       enumeration[MEDIA_DEVICE_TYPE_AUDIO_OUTPUT]) {
+    if (content::DoesMediaDeviceIDMatchHMAC(salt_, security_origin, device_id,
+                                            device_info.device_id)) {
+      base::PostTaskAndReplyWithResult(
+          media::AudioManager::Get()->GetTaskRunner(), FROM_HERE,
+          base::Bind(&GetDeviceParametersOnDeviceThread, device_info.device_id),
+          base::Bind(&AudioOutputAuthorizationHandler::DeviceParametersReceived,
+                     weak_factory_.GetWeakPtr(), std::move(cb),
+                     device_info.device_id));
+      return;
+    }
+  }
+  cb.Run(media::OUTPUT_DEVICE_STATUS_ERROR_NOT_FOUND,

[o1ka, 2016/11/14 13:24:04]

guidou@ What do you think of having LOG() messages for all authorization
failures? Won't it help debugging?

+         media::AudioParameters::UnavailableDeviceParams(), std::string());
+}
+
+void AudioOutputAuthorizationHandler::DeviceParametersReceived(
+    AuthorizationCompletedCallback cb,
+    const std::string& translated_device_id,
+    const media::AudioParameters& output_params) const {
+  DCHECK_CURRENTLY_ON(BrowserThread::IO);
+  DCHECK(!translated_device_id.empty());
+
+  cb.Run(media::OUTPUT_DEVICE_STATUS_OK,
+         output_params.IsValid() ? output_params
+                                 : MaybeFixAudioParameters(output_params),
+         translated_device_id);
+}
+
+}  // namespace content