Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 2424113002: Revert of Add IGNORE_DEPS_CHANGES flag and coverage builder. (Closed)

Created:
4 years, 2 months ago by dnj
Modified:
4 years, 2 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Revert of Add IGNORE_DEPS_CHANGES flag and coverage builder. (patchset #3 id:40001 of https://codereview.chromium.org/2418233002/ ) Reason for revert: Team says they don't need the builder that this supports, so remove the code. Original issue's description: > Add IGNORE_DEPS_CHANGES flag and coverage builder. > > Add a flag to "chromium" recipe module to export the IGNORE_DEPS_CHANGES > environment variable. Since this is used outside of the "build" > repository, add a fake builder to exercise this option for coverage. > > BUG=chromium:648308 > TEST=None > > Committed: https://chromium.googlesource.com/chromium/tools/build/+/02bbb17974a70e1bb198ee4243d830ff258d1bb8 TBR=dpranke@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:648308 Committed: https://chromium.googlesource.com/chromium/tools/build/+/9f623ff560eeca917efb9b799a1ca3137f9dcaa0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -379 lines) Patch
M scripts/slave/recipe_modules/chromium/api.py View 1 chunk +0 lines, -2 lines 0 comments Download
M scripts/slave/recipe_modules/chromium/config.py View 2 chunks +0 lines, -5 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_tests/builders.py View 2 chunks +0 lines, -21 lines 0 comments Download
D scripts/slave/recipes/chromium.expected/full_bot_update_always_on_Package_Builder__Coverage_.json View 1 chunk +0 lines, -351 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
dnj
Created Revert of Add IGNORE_DEPS_CHANGES flag and coverage builder.
4 years, 2 months ago (2016-10-17 18:23:52 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2424113002/1
4 years, 2 months ago (2016-10-17 18:23:57 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/tools/build/+/9f623ff560eeca917efb9b799a1ca3137f9dcaa0
4 years, 2 months ago (2016-10-17 18:24:06 UTC) #5
Dirk Pranke
4 years, 2 months ago (2016-10-17 18:24:36 UTC) #6
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698