Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9114)

Unified Diff: chrome/installer/linux/common/installer.include

Issue 2424093003: Include the AppData file for Chrome and Chromium (Closed)
Patch Set: Add screenshot, feedback link and fix some of appstream-util validation warnings Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/installer/linux/common/installer.include
diff --git a/chrome/installer/linux/common/installer.include b/chrome/installer/linux/common/installer.include
index d606238d6476e22444fc65c0d4c1ed76d50e063a..c2cb10919aaa43ed138c68c300714e175cf1928b 100644
--- a/chrome/installer/linux/common/installer.include
+++ b/chrome/installer/linux/common/installer.include
@@ -228,6 +228,14 @@ stage_install_common() {
# desktop integration
install -m 755 "${BUILDDIR}/xdg-mime" "${STAGEDIR}${INSTALLDIR}/"
install -m 755 "${BUILDDIR}/xdg-settings" "${STAGEDIR}${INSTALLDIR}/"
+ if [ ${PACKAGE:0:6} = google ]; then
Lei Zhang 2017/07/25 22:13:58 Curious, why not just check ${PACKAGE} ? The only
+ process_template "${BUILDDIR}/installer/common/google-chrome/google-chrome.appdata.xml.template" \
+ "${STAGEDIR}/usr/share/appdata/${PACKAGE}.appdata.xml"
+ chmod 644 "${STAGEDIR}/usr/share/appdata/${PACKAGE}.appdata.xml"
+ else
+ install -m 644 "${BUILDDIR}/installer/common/chromium-browser/chromium-browser.appdata.xml" \
+ "${STAGEDIR}/usr/share/appdata/${PACKAGE}.appdata.xml"
+ fi
process_template "${BUILDDIR}/installer/common/desktop.template" \
"${STAGEDIR}/usr/share/applications/${PACKAGE}.desktop"
chmod 644 "${STAGEDIR}/usr/share/applications/${PACKAGE}.desktop"

Powered by Google App Engine
This is Rietveld 408576698