Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 2424033003: Slightly increase the size of the CBD dialog body to hint at scrolling (Closed)

Created:
4 years, 2 months ago by msramek
Modified:
4 years, 2 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2883
Project:
chromium
Visibility:
Public.

Description

Slightly increase the size of the CBD dialog body to hint at scrolling When opened in a small browser window, the CBD dialog is set to a size in which 4 checkboxes are visible*, and the remaining 4 are below the fold and need to be scrolled to. [*]the label of the 5th is slightly visible if checked While the scrollbar is usually visible, this is not the case on Mac (where it's only visible while scrolling is in progress). Other visual cues for scrolling are not applicable - the top and bottom border of paper-dialog-scrollable are not visible because the dialog body has its own borders, and shadows are not yet implemented. As discussed in the linked bug, until a general solution is applied to all such MD scrolling dialogs, we need a one-off solution for this case as it's particularly sensitive. This CL increases the size of the dialog body to hold 4.5 checkboxes, so the need to scroll is obvious. Note that this was also the original design; this CL fixes a regression. BUG=652027 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2403833002 Cr-Commit-Position: refs/heads/master@{#424400} (cherry picked from commit ae25baeb7a5af9dad6ae2f8ad050d5564301d30d) Committed: https://chromium.googlesource.com/chromium/src/+/1d67536fa92ec902dc3cbc715abce8306f2e8f3d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.html View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
msramek
4 years, 2 months ago (2016-10-17 15:37:57 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1d67536fa92ec902dc3cbc715abce8306f2e8f3d.

Powered by Google App Engine
This is Rietveld 408576698