Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2424033002:
📰 Update the strings for the empty state cards (Closed)
|
Created:
4 years, 2 months ago by dgn Modified:
4 years, 2 months ago Reviewers:
Bernhard Bauer CC:
chromium-reviews Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[NTP Client] Update the strings for the empty state cards
Does not add or change any resource id.
BUG=656634
Committed: https://crrev.com/9116cbaf9ff03d697add0a6b2206f306ac55301b
Cr-Commit-Position: refs/heads/master@{#426000}
Patch Set 1 #
Total comments: 3
Patch Set 2 : s/'/’ #Messages
Total messages: 20 (13 generated)
The CQ bit was checked by dgn@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
dgn@chromium.org changed reviewers: + bauerb@chromium.org
PTAL
Description was changed from ========== [NTP Client] Update the strings for the empty state cards Does not add or change any resource id. BUG=656634 ========== to ========== [NTP Client] Update the strings for the empty state cards Does not add or change any resource id. BUG=656634 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
https://codereview.chromium.org/2424033002/diff/1/components/ntp_snippets_str... File components/ntp_snippets_strings.grdp (right): https://codereview.chromium.org/2424033002/diff/1/components/ntp_snippets_str... components/ntp_snippets_strings.grdp:12: That's all for now For strings that are used in Android UI, please use a "curly" quote character (’, U+2019) instead of the straight quote (', U+0027).
The CQ bit was checked by dgn@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
https://codereview.chromium.org/2424033002/diff/1/components/ntp_snippets_str... File components/ntp_snippets_strings.grdp (right): https://codereview.chromium.org/2424033002/diff/1/components/ntp_snippets_str... components/ntp_snippets_strings.grdp:12: That's all for now On 2016/10/17 16:16:00, Bernhard Bauer wrote: > For strings that are used in Android UI, please use a "curly" quote character > (’, U+2019) instead of the straight quote (', U+0027). Thanks, I had no idea. Where is this quote from?
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Thanks, LGTM. https://codereview.chromium.org/2424033002/diff/1/components/ntp_snippets_str... File components/ntp_snippets_strings.grdp (right): https://codereview.chromium.org/2424033002/diff/1/components/ntp_snippets_str... components/ntp_snippets_strings.grdp:12: That's all for now On 2016/10/17 17:05:37, dgn wrote: > On 2016/10/17 16:16:00, Bernhard Bauer wrote: > > For strings that are used in Android UI, please use a "curly" quote character > > (’, U+2019) instead of the straight quote (', U+0027). > > Thanks, I had no idea. Where is this quote from? The character itself is the RIGHT SINGLE QUOTATION MARK Unicode code point (which I copied from a Unicode table). The relevant style guide reference is https://material.google.com/style/writing.html#writing-capitalization-punctua....
The CQ bit was checked by dgn@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== [NTP Client] Update the strings for the empty state cards Does not add or change any resource id. BUG=656634 ========== to ========== [NTP Client] Update the strings for the empty state cards Does not add or change any resource id. BUG=656634 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== [NTP Client] Update the strings for the empty state cards Does not add or change any resource id. BUG=656634 ========== to ========== [NTP Client] Update the strings for the empty state cards Does not add or change any resource id. BUG=656634 Committed: https://crrev.com/9116cbaf9ff03d697add0a6b2206f306ac55301b Cr-Commit-Position: refs/heads/master@{#426000} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/9116cbaf9ff03d697add0a6b2206f306ac55301b Cr-Commit-Position: refs/heads/master@{#426000} |
