Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(504)

Issue 2424013002: Add support to trace preparsing decisions (Closed)

Created:
4 years, 2 months ago by Toon Verwaest
Modified:
4 years, 2 months ago
Reviewers:
marja
CC:
v8-reviews_googlegroups.com, Michael Hablich
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Add support to trace preparsing decisions BUG=v8:5501 Committed: https://crrev.com/c4e7992cf79c462538549fe758485e3dd40054b3 Cr-Commit-Position: refs/heads/master@{#40383}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -2 lines) Patch
M src/flag-definitions.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/parsing/parser.cc View 1 chunk +11 lines, -1 line 0 comments Download
M src/parsing/preparser.cc View 1 chunk +9 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Toon Verwaest
ptal
4 years, 2 months ago (2016-10-17 14:39:31 UTC) #2
marja
lgtm
4 years, 2 months ago (2016-10-18 06:54:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2424013002/1
4 years, 2 months ago (2016-10-18 07:33:27 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-18 08:00:08 UTC) #6
commit-bot: I haz the power
4 years, 2 months ago (2016-10-18 08:00:44 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c4e7992cf79c462538549fe758485e3dd40054b3
Cr-Commit-Position: refs/heads/master@{#40383}

Powered by Google App Engine
This is Rietveld 408576698