The CQ bit was checked by henrika@chromium.org
Created Revert of Optimize blink scheduler with an intrusive heap
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Failed to apply patch for third_party/WebKit/Source/platform/BUILD.gn: While running git apply --index -3 -p1; error: patch failed: third_party/WebKit/Source/platform/BUILD.gn:1127 error: repository lacks the necessary blob to fall back on 3-way merge. error: third_party/WebKit/Source/platform/BUILD.gn: patch does not apply Patch: third_party/WebKit/Source/platform/BUILD.gn Index: third_party/WebKit/Source/platform/BUILD.gn diff --git a/third_party/WebKit/Source/platform/BUILD.gn b/third_party/WebKit/Source/platform/BUILD.gn index 29a2eb7c0263b1bd850fe3ce8f53d8c318f49e00..1fa210477ccf83ae3e94fddeba54d263e25254d5 100644 --- a/third_party/WebKit/Source/platform/BUILD.gn +++ b/third_party/WebKit/Source/platform/BUILD.gn @@ -1127,7 +1127,6 @@ "scheduler/base/cancelable_closure_holder.h", "scheduler/base/enqueue_order.cc", "scheduler/base/enqueue_order.h", - "scheduler/base/intrusive_heap.h", "scheduler/base/lazy_now.cc", "scheduler/base/lazy_now.h", "scheduler/base/pollable_thread_safe_flag.cc", @@ -1705,7 +1704,6 @@ "network/ResourceRequestTest.cpp", "network/ResourceResponseTest.cpp", "scheduler/CancellableTaskFactoryTest.cpp", - "scheduler/base/intrusive_heap_unittest.cc", "scheduler/base/queueing_time_estimator_unittest.cc", "scheduler/base/task_queue_manager_unittest.cc", "scheduler/base/task_queue_selector_unittest.cc",
Please ignore. Had already reverted :-)
Description was changed from ========== Revert of Optimize blink scheduler with an intrusive heap (patchset #11 id:200001 of https://codereview.chromium.org/2419793002/ ) Reason for revert: Seems to break many tests on many platforms. Example: https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.win%2FWin7_Test... Original issue's description: > Optimize blink scheduler with an intrusive heap > > BUG= > > Committed: https://crrev.com/36d98e3b544f310943986dcaa98beabacdbccc96 > Cr-Commit-Position: refs/heads/master@{#425647} TBR=skyostil@chromium.org,haraken@chromium.org,yutak@chromium.org,altimin@chr... # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= ========== to ========== Revert of Optimize blink scheduler with an intrusive heap (patchset #11 id:200001 of https://codereview.chromium.org/2419793002/ ) Reason for revert: Seems to break many tests on many platforms. Example: https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.win%2FWin7_Test... Original issue's description: > Optimize blink scheduler with an intrusive heap > > BUG= > > Committed: https://crrev.com/36d98e3b544f310943986dcaa98beabacdbccc96 > Cr-Commit-Position: refs/heads/master@{#425647} TBR=skyostil@chromium.org,haraken@chromium.org,yutak@chromium.org,altimin@chr... # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= ==========
alexclarke@chromium.org changed reviewers: - alexclarke@chromium.org
altimin@chromium.org changed reviewers: - altimin@chromium.org
Chromium Code Reviews
Issue
2424003002:
Revert of Optimize blink scheduler with an intrusive heap (Closed)
