Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(740)

Unified Diff: sdk/lib/typed_data/typed_data.dart

Issue 24240020: Cleanup bit casting methods between SIMD types (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/typed_data/typed_data.dart
diff --git a/sdk/lib/typed_data/typed_data.dart b/sdk/lib/typed_data/typed_data.dart
index 61577b2e067fc7991aad64a6c68ef1255a281cf1..e18433ecddff18828f8462749547cb5efd38237e 100644
--- a/sdk/lib/typed_data/typed_data.dart
+++ b/sdk/lib/typed_data/typed_data.dart
@@ -834,6 +834,7 @@ abstract class Float32x4 {
external factory Float32x4(double x, double y, double z, double w);
external factory Float32x4.splat(double v);
external factory Float32x4.zero();
+ external factory Float32x4.fromUint32x4Bits(Uint32x4 x);
/// Addition operator.
Float32x4 operator+(Float32x4 other);
@@ -1183,9 +1184,6 @@ abstract class Float32x4 {
/// Returns the square root of the reciprocal of [this].
Float32x4 reciprocalSqrt();
-
- /// Returns a bit-wise copy of [this] as a [Uint32x4].
- Uint32x4 toUint32x4();
}
@@ -1197,6 +1195,7 @@ abstract class Float32x4 {
abstract class Uint32x4 {
external factory Uint32x4(int x, int y, int z, int w);
external factory Uint32x4.bool(bool x, bool y, bool z, bool w);
+ external factory Uint32x4.fromFloat32x4Bits(Float32x4 x);
/// The bit-wise or operator.
Uint32x4 operator|(Uint32x4 other);
@@ -1252,7 +1251,4 @@ abstract class Uint32x4 {
/// Select bit from [trueValue] when bit in [this] is on.
/// Select bit from [falseValue] when bit in [this] is off.
Float32x4 select(Float32x4 trueValue, Float32x4 falseValue);
-
- /// Returns a bit-wise copy of [this] as a [Float32x4].
- Float32x4 toFloat32x4();
}

Powered by Google App Engine
This is Rietveld 408576698