Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(690)

Unified Diff: runtime/lib/simd128.cc

Issue 24240020: Cleanup bit casting methods between SIMD types (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/lib/typed_data.dart » ('j') | runtime/lib/typed_data.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/lib/simd128.cc
diff --git a/runtime/lib/simd128.cc b/runtime/lib/simd128.cc
index d128e83a343389d239202efb3fb79f60cbb65cf5..ceb641480624ba9ea3b53c27e116890ad3ed5df3 100644
--- a/runtime/lib/simd128.cc
+++ b/runtime/lib/simd128.cc
@@ -42,6 +42,12 @@ DEFINE_NATIVE_ENTRY(Float32x4_zero, 1) {
}
+DEFINE_NATIVE_ENTRY(Float32x4_fromUint32x4bits, 2) {
zra 2013/09/24 00:29:09 Float32x4_fromUint32x4Bits with a large B.
Cutch 2013/09/24 16:00:05 Done.
+ GET_NON_NULL_NATIVE_ARGUMENT(Uint32x4, v, arguments->NativeArgAt(1));
+ return Float32x4::New(v.value());
+}
+
+
DEFINE_NATIVE_ENTRY(Float32x4_add, 2) {
GET_NON_NULL_NATIVE_ARGUMENT(Float32x4, self, arguments->NativeArgAt(0));
GET_NON_NULL_NATIVE_ARGUMENT(Float32x4, other, arguments->NativeArgAt(1));
@@ -425,12 +431,6 @@ DEFINE_NATIVE_ENTRY(Float32x4_reciprocalSqrt, 1) {
}
-DEFINE_NATIVE_ENTRY(Float32x4_toUint32x4, 1) {
- GET_NON_NULL_NATIVE_ARGUMENT(Float32x4, v, arguments->NativeArgAt(0));
- return Uint32x4::New(v.value());
-}
-
-
DEFINE_NATIVE_ENTRY(Uint32x4_fromInts, 5) {
ASSERT(AbstractTypeArguments::CheckedHandle(
arguments->NativeArgAt(0)).IsNull());
@@ -461,6 +461,12 @@ DEFINE_NATIVE_ENTRY(Uint32x4_fromBools, 5) {
}
+DEFINE_NATIVE_ENTRY(Uint32x4_fromFloat32x4Bits, 2) {
+ GET_NON_NULL_NATIVE_ARGUMENT(Float32x4, v, arguments->NativeArgAt(1));
+ return Uint32x4::New(v.value());
+}
+
+
DEFINE_NATIVE_ENTRY(Uint32x4_or, 2) {
GET_NON_NULL_NATIVE_ARGUMENT(Uint32x4, self, arguments->NativeArgAt(0));
GET_NON_NULL_NATIVE_ARGUMENT(Uint32x4, other, arguments->NativeArgAt(1));
@@ -704,10 +710,4 @@ DEFINE_NATIVE_ENTRY(Uint32x4_select, 3) {
}
-DEFINE_NATIVE_ENTRY(Uint32x4_toFloat32x4, 1) {
- GET_NON_NULL_NATIVE_ARGUMENT(Uint32x4, v, arguments->NativeArgAt(0));
- return Float32x4::New(v.value());
-}
-
-
} // namespace dart
« no previous file with comments | « no previous file | runtime/lib/typed_data.dart » ('j') | runtime/lib/typed_data.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698