Cleanup bit casting methods between SIMD types

runtime/lib/simd128.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/bootstrap_natives.h"
 
 #include "vm/exceptions.h"
 #include "vm/native_entry.h"
 #include "vm/object.h"
 #include "vm/symbols.h"
@@ skipping 24 matching lines @@
 }
 
 
 DEFINE_NATIVE_ENTRY(Float32x4_zero, 1) {
   ASSERT(AbstractTypeArguments::CheckedHandle(
       arguments->NativeArgAt(0)).IsNull());
   return Float32x4::New(0.0f, 0.0f, 0.0f, 0.0f);
 }
 
 
+DEFINE_NATIVE_ENTRY(Float32x4_fromUint32x4bits, 2) {

[zra, 2013/09/24 00:29:09]

Float32x4_fromUint32x4Bits with a large B.

[Cutch, 2013/09/24 16:00:05]

Done.

+  GET_NON_NULL_NATIVE_ARGUMENT(Uint32x4, v, arguments->NativeArgAt(1));
+  return Float32x4::New(v.value());
+}
+
+
 DEFINE_NATIVE_ENTRY(Float32x4_add, 2) {
   GET_NON_NULL_NATIVE_ARGUMENT(Float32x4, self, arguments->NativeArgAt(0));
   GET_NON_NULL_NATIVE_ARGUMENT(Float32x4, other, arguments->NativeArgAt(1));
   float _x = self.x() + other.x();
   float _y = self.y() + other.y();
   float _z = self.z() + other.z();
   float _w = self.w() + other.w();
   return Float32x4::New(_x, _y, _z, _w);
 }
 
@@ skipping 363 matching lines @@
 DEFINE_NATIVE_ENTRY(Float32x4_reciprocalSqrt, 1) {
   GET_NON_NULL_NATIVE_ARGUMENT(Float32x4, self, arguments->NativeArgAt(0));
   float _x = sqrtf(1.0f / self.x());
   float _y = sqrtf(1.0f / self.y());
   float _z = sqrtf(1.0f / self.z());
   float _w = sqrtf(1.0f / self.w());
   return Float32x4::New(_x, _y, _z, _w);
 }
 
 
-DEFINE_NATIVE_ENTRY(Float32x4_toUint32x4, 1) {
-  GET_NON_NULL_NATIVE_ARGUMENT(Float32x4, v, arguments->NativeArgAt(0));
-  return Uint32x4::New(v.value());
-}
-
-
 DEFINE_NATIVE_ENTRY(Uint32x4_fromInts, 5) {
   ASSERT(AbstractTypeArguments::CheckedHandle(
       arguments->NativeArgAt(0)).IsNull());
   GET_NON_NULL_NATIVE_ARGUMENT(Integer, x, arguments->NativeArgAt(1));
   GET_NON_NULL_NATIVE_ARGUMENT(Integer, y, arguments->NativeArgAt(2));
   GET_NON_NULL_NATIVE_ARGUMENT(Integer, z, arguments->NativeArgAt(3));
   GET_NON_NULL_NATIVE_ARGUMENT(Integer, w, arguments->NativeArgAt(4));
   uint32_t _x = static_cast<uint32_t>(x.AsInt64Value() & 0xFFFFFFFF);
   uint32_t _y = static_cast<uint32_t>(y.AsInt64Value() & 0xFFFFFFFF);
   uint32_t _z = static_cast<uint32_t>(z.AsInt64Value() & 0xFFFFFFFF);
@@ skipping 10 matching lines @@
   GET_NON_NULL_NATIVE_ARGUMENT(Bool, z, arguments->NativeArgAt(3));
   GET_NON_NULL_NATIVE_ARGUMENT(Bool, w, arguments->NativeArgAt(4));
   uint32_t _x = x.value() ? 0xFFFFFFFF : 0x0;
   uint32_t _y = y.value() ? 0xFFFFFFFF : 0x0;
   uint32_t _z = z.value() ? 0xFFFFFFFF : 0x0;
   uint32_t _w = w.value() ? 0xFFFFFFFF : 0x0;
   return Uint32x4::New(_x, _y, _z, _w);
 }
 
 
+DEFINE_NATIVE_ENTRY(Uint32x4_fromFloat32x4Bits, 2) {
+  GET_NON_NULL_NATIVE_ARGUMENT(Float32x4, v, arguments->NativeArgAt(1));
+  return Uint32x4::New(v.value());
+}
+
+
 DEFINE_NATIVE_ENTRY(Uint32x4_or, 2) {
   GET_NON_NULL_NATIVE_ARGUMENT(Uint32x4, self, arguments->NativeArgAt(0));
   GET_NON_NULL_NATIVE_ARGUMENT(Uint32x4, other, arguments->NativeArgAt(1));
   uint32_t _x = self.x() | other.x();
   uint32_t _y = self.y() | other.y();
   uint32_t _z = self.z() | other.z();
   uint32_t _w = self.w() | other.w();
   return Uint32x4::New(_x, _y, _z, _w);
 }
 
@@ skipping 223 matching lines @@
   float32_uint32 fvw(fv.w());
   // Perform select.
   float32_uint32 tempX((_maskX & tvx.u) | (~_maskX & fvx.u));
   float32_uint32 tempY((_maskY & tvy.u) | (~_maskY & fvy.u));
   float32_uint32 tempZ((_maskZ & tvz.u) | (~_maskZ & fvz.u));
   float32_uint32 tempW((_maskW & tvw.u) | (~_maskW & fvw.u));
   return Float32x4::New(tempX.f, tempY.f, tempZ.f, tempW.f);
 }
 
 
-DEFINE_NATIVE_ENTRY(Uint32x4_toFloat32x4, 1) {
-  GET_NON_NULL_NATIVE_ARGUMENT(Uint32x4, v, arguments->NativeArgAt(0));
-  return Float32x4::New(v.value());
-}
-
-
 }  // namespace dart