Emphasize that durations are context independent.

Emphasize that durations are context independent.

Fixes #27597
BUG= http://dartbug.com/27597
R=lrn@google.com

Committed: https://github.com/dart-lang/sdk/commit/8fbd651c497a01f62b286a1a40607be748b657bb

[floitsch, 2016-10-17 12:29:53]

floitsch@google.com changed reviewers:
+ lrn@google.com

[Lasse Reichstein Nielsen, 2016-10-17 12:40:13]

lgtm

https://codereview.chromium.org/2423993002/diff/40001/sdk/lib/core/date_time....
File sdk/lib/core/date_time.dart (right):

https://codereview.chromium.org/2423993002/diff/40001/sdk/lib/core/date_time....
sdk/lib/core/date_time.dart:577: * Notice that the duration being added is
actually 60 * 24 * 60 * 60
Pick a number of days different from 60, it's confusing with the min/hr and
sec/min 60's.

https://codereview.chromium.org/2423993002/diff/40001/sdk/lib/core/date_time....
sdk/lib/core/date_time.dart:578: * seconds and if that crosses a daylight saving
time change, the resulting
if that -> if this `DateTime` has non-UTC time zone and adding that number of
seconds to the `DateTime` ...

https://codereview.chromium.org/2423993002/diff/40001/sdk/lib/core/date_time....
sdk/lib/core/date_time.dart:592: * Notice that the duration being subtracted is
actually 60 * 24 * 60 * 60
same as above (except adding->subtracting).

https://codereview.chromium.org/2423993002/diff/40001/sdk/lib/core/duration.dart
File sdk/lib/core/duration.dart (right):

https://codereview.chromium.org/2423993002/diff/40001/sdk/lib/core/duration.d...
sdk/lib/core/duration.dart:21: * only uses these arguments to compute the
corresponding time intervall.
compute the corresponding -> compute the length of the corresponding

[floitsch, 2016-10-17 12:50:25]

https://codereview.chromium.org/2423993002/diff/40001/sdk/lib/core/date_time....
File sdk/lib/core/date_time.dart (right):

https://codereview.chromium.org/2423993002/diff/40001/sdk/lib/core/date_time....
sdk/lib/core/date_time.dart:577: * Notice that the duration being added is
actually 60 * 24 * 60 * 60
On 2016/10/17 12:40:12, Lasse Reichstein Nielsen wrote:
> Pick a number of days different from 60, it's confusing with the min/hr and
> sec/min 60's.

Done.

https://codereview.chromium.org/2423993002/diff/40001/sdk/lib/core/date_time....
sdk/lib/core/date_time.dart:578: * seconds and if that crosses a daylight saving
time change, the resulting
On 2016/10/17 12:40:12, Lasse Reichstein Nielsen wrote:
> if that -> if this `DateTime` has non-UTC time zone and adding that number of
> seconds to the `DateTime` ...

Done.

https://codereview.chromium.org/2423993002/diff/40001/sdk/lib/core/date_time....
sdk/lib/core/date_time.dart:592: * Notice that the duration being subtracted is
actually 60 * 24 * 60 * 60
On 2016/10/17 12:40:12, Lasse Reichstein Nielsen wrote:
> same as above (except adding->subtracting).

Done.

https://codereview.chromium.org/2423993002/diff/40001/sdk/lib/core/duration.dart
File sdk/lib/core/duration.dart (right):

https://codereview.chromium.org/2423993002/diff/40001/sdk/lib/core/duration.d...
sdk/lib/core/duration.dart:21: * only uses these arguments to compute the
corresponding time intervall.
On 2016/10/17 12:40:12, Lasse Reichstein Nielsen wrote:
> compute the corresponding -> compute the length of the corresponding

Done.

[floitsch, 2016-10-17 12:51:06]

Description was changed from

==========
Emphasize that durations are context independent.

Fixes #27597
BUG= http://dartbug.com/27597
==========

to

==========
Emphasize that durations are context independent.

Fixes #27597
BUG= http://dartbug.com/27597
R=lrn@google.com

Committed:
https://github.com/dart-lang/sdk/commit/8fbd651c497a01f62b286a1a40607be748b657bb
==========

[floitsch, 2016-10-17 12:51:08]

Committed patchset #4 (id:60001) manually as
8fbd651c497a01f62b286a1a40607be748b657bb (presubmit successful).