Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 2423983002: Limit PDF helper extension to print preview only (Closed)

Created:
4 years, 2 months ago by robwu
Modified:
4 years, 2 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2883
Project:
chromium
Visibility:
Public.

Description

Limit PDF helper extension to print preview only These days, the helper extension is only used by the print preview. So make sure that the helper extension is only activated in print previews and fall back to the standard MimeHandler otherwise. When the helper extension is unexpectedly loaded directly instead of through the mime handler, the extension will fail to initialize. This is totally desired! BUG=654280 TEST=See bug report, also confirmed that print preview still works. R=thestig@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2407713002 Cr-Commit-Position: refs/heads/master@{#425280} (cherry picked from commit c72f59f36a16c0cb64e0eebfc0999a09250740f0) Committed: https://chromium.googlesource.com/chromium/src/+/37efdf4c7fdae4c604ad0b71781c36182b1517f0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -67 lines) Patch
M chrome/browser/pdf/pdf_extension_test.cc View 1 chunk +18 lines, -0 lines 0 comments Download
M chrome/browser/resources/pdf/browser_api.js View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/resources/pdf/pdf.js View 1 chunk +1 line, -1 line 0 comments Download
M content/public/test/browser_test_utils.h View 2 chunks +32 lines, -0 lines 0 comments Download
M content/public/test/browser_test_utils.cc View 2 chunks +29 lines, -0 lines 0 comments Download
M content/public/test/content_browser_test_utils.h View 3 chunks +1 line, -33 lines 0 comments Download
M content/public/test/content_browser_test_utils.cc View 2 chunks +0 lines, -30 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
robwu
Committed patchset #1 (id:1) manually as 37efdf4c7fdae4c604ad0b71781c36182b1517f0.
4 years, 2 months ago (2016-10-17 12:01:54 UTC) #2
Lei Zhang
4 years, 2 months ago (2016-10-17 22:05:37 UTC) #3
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698