Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(300)

Unified Diff: pkg/compiler/lib/src/universe/world_builder.dart

Issue 2423953002: Change TypeInference to handle super calls as direct invocations. (Closed)
Patch Set: Register instance methods from direct invocation. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/universe/world_builder.dart
diff --git a/pkg/compiler/lib/src/universe/world_builder.dart b/pkg/compiler/lib/src/universe/world_builder.dart
index b69732556955a42c3766d3ee02e8ae01e5ddbdc7..d574f3ae4b6518bd9a822a8d76bdbae1c51818fe 100644
--- a/pkg/compiler/lib/src/universe/world_builder.dart
+++ b/pkg/compiler/lib/src/universe/world_builder.dart
@@ -379,6 +379,10 @@ class ResolutionWorldBuilderImpl implements ResolutionWorldBuilder {
case StaticUseKind.CLOSURE:
allClosures.add(element);
break;
+ case StaticUseKind.DIRECT_INVOKE:
+ invariant(
+ element, 'Direct static use is not supported for resolution.');
+ break;
}
}
@@ -519,7 +523,7 @@ class CodegenWorldBuilderImpl implements CodegenWorldBuilder {
isNative
// Likewise, if this registration comes from the mirror system,
// all bets are off.
- // TODO(herhut): Track classes required by mirrors seperately.
+ // TODO(herhut): Track classes required by mirrors separately.
||
byMirrors) {
_directlyInstantiatedClasses.add(cls);
@@ -651,6 +655,7 @@ class CodegenWorldBuilderImpl implements CodegenWorldBuilder {
case StaticUseKind.FIELD_GET:
case StaticUseKind.CONSTRUCTOR_INVOKE:
case StaticUseKind.CONST_CONSTRUCTOR_INVOKE:
+ case StaticUseKind.DIRECT_INVOKE:
break;
}
}

Powered by Google App Engine
This is Rietveld 408576698