Change TypeInference to handle super calls as direct invocations.

Change TypeInference to handle super calls as direct invocations.

This also makes calls of known target registered as static uses and thus
removes the need for misusing type masks to select super methods.

Closes #25716

R=sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/70159b741886b0bb10c3c6f77d7a0d0109131320

Reverted: https://github.com/dart-lang/sdk/commit/5397c5427e9102a8ea7602174be2664d4c15bb8b
Committed: https://github.com/dart-lang/sdk/commit/37afcd5197bb408a4fbfc76bb8fb521ddbb1ca25

[Johnni Winther, 2016-10-17 10:59:03]

johnniwinther@google.com changed reviewers:
+ sigmund@google.com

[Siggi Cherem (dart-lang), 2016-10-17 19:55:36]

lgtm, minor suggestions & questions below

https://codereview.chromium.org/2423953002/diff/20001/pkg/compiler/lib/src/in...
File pkg/compiler/lib/src/inferrer/simple_types_inferrer.dart (right):

https://codereview.chromium.org/2423953002/diff/20001/pkg/compiler/lib/src/in...
pkg/compiler/lib/src/inferrer/simple_types_inferrer.dart:911: Selector
operatorSelector =
nit: move this and operatorMask into the else branch below (the only place where
it is used)

https://codereview.chromium.org/2423953002/diff/20001/pkg/compiler/lib/src/in...
pkg/compiler/lib/src/inferrer/simple_types_inferrer.dart:934: }
nit: rewrite as
  return node.isPostfix ? getterType : returnType;

https://codereview.chromium.org/2423953002/diff/20001/pkg/compiler/lib/src/in...
pkg/compiler/lib/src/inferrer/simple_types_inferrer.dart:1276: Selector
operatorSelector =
similarly comments here (as in the _handleSuperCompuoundIndexSet)

https://codereview.chromium.org/2423953002/diff/20001/pkg/compiler/lib/src/ss...
File pkg/compiler/lib/src/ssa/codegen.dart (right):

https://codereview.chromium.org/2423953002/diff/20001/pkg/compiler/lib/src/ss...
pkg/compiler/lib/src/ssa/codegen.dart:1695: new StaticUse.directInvoke(target,
selector.callStructure));
I'm guessing this is a nSM? Maybe document it as such?

https://codereview.chromium.org/2423953002/diff/20001/pkg/compiler/lib/src/ss...
pkg/compiler/lib/src/ssa/codegen.dart:1703: if (node.element != null) {
same here and below?

[Johnni Winther, 2016-10-18 07:46:27]

https://codereview.chromium.org/2423953002/diff/20001/pkg/compiler/lib/src/in...
File pkg/compiler/lib/src/inferrer/simple_types_inferrer.dart (right):

https://codereview.chromium.org/2423953002/diff/20001/pkg/compiler/lib/src/in...
pkg/compiler/lib/src/inferrer/simple_types_inferrer.dart:1276: Selector
operatorSelector =
On 2016/10/17 19:55:36, Siggi Cherem (dart-lang) wrote:
> similarly comments here (as in the _handleSuperCompuoundIndexSet)

Done.

https://codereview.chromium.org/2423953002/diff/20001/pkg/compiler/lib/src/ss...
File pkg/compiler/lib/src/ssa/codegen.dart (right):

https://codereview.chromium.org/2423953002/diff/20001/pkg/compiler/lib/src/ss...
pkg/compiler/lib/src/ssa/codegen.dart:1695: new StaticUse.directInvoke(target,
selector.callStructure));
On 2016/10/17 19:55:36, Siggi Cherem (dart-lang) wrote:
> I'm guessing this is a nSM? Maybe document it as such?

No. This is a dynamic invocation which we have found to have a single target but
for some reason haven't inlined. We are _still_ accessing the target dynamically
but we don't need to enqueue more than target for this to work. 

Add this as a comment.

https://codereview.chromium.org/2423953002/diff/20001/pkg/compiler/lib/src/ss...
pkg/compiler/lib/src/ssa/codegen.dart:1703: if (node.element != null) {
On 2016/10/17 19:55:36, Siggi Cherem (dart-lang) wrote:
> same here and below?

Added comment.

[Johnni Winther, 2016-10-18 07:46:37]

Description was changed from

==========
Change TypeInference to handle super calls as direct invocations.

This also makes calls of known target registered as static uses and thus
removes the need for misusing type masks to select super methods.

Closes #25716
==========

to

==========
Change TypeInference to handle super calls as direct invocations.

This also makes calls of known target registered as static uses and thus
removes the need for misusing type masks to select super methods.

Closes #25716

R=sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/70159b741886b0bb10c3c6f77d7a0d0109131320
==========

[Johnni Winther, 2016-10-18 07:46:38]

Committed patchset #3 (id:40001) manually as
70159b741886b0bb10c3c6f77d7a0d0109131320 (presubmit successful).

[Johnni Winther, 2016-10-18 10:39:38]

Description was changed from

==========
Change TypeInference to handle super calls as direct invocations.

This also makes calls of known target registered as static uses and thus
removes the need for misusing type masks to select super methods.

Closes #25716

R=sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/70159b741886b0bb10c3c6f77d7a0d0109131320
==========

to

==========
Change TypeInference to handle super calls as direct invocations.

This also makes calls of known target registered as static uses and thus
removes the need for misusing type masks to select super methods.

Closes #25716

R=sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/70159b741886b0bb10c3c6f77d7a0d0109131320

Reverted:
https://github.com/dart-lang/sdk/commit/5397c5427e9102a8ea7602174be2664d4c15bb8b
==========

[Johnni Winther, 2016-10-18 12:02:34]

PTAL at the last patch

[Johnni Winther, 2016-10-18 12:03:09]

Description was changed from

==========
Change TypeInference to handle super calls as direct invocations.

This also makes calls of known target registered as static uses and thus
removes the need for misusing type masks to select super methods.

Closes #25716

R=sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/70159b741886b0bb10c3c6f77d7a0d0109131320

Reverted:
https://github.com/dart-lang/sdk/commit/5397c5427e9102a8ea7602174be2664d4c15bb8b
==========

to

==========
Change TypeInference to handle super calls as direct invocations.

This also makes calls of known target registered as static uses and thus
removes the need for misusing type masks to select super methods.

Closes #25716

R=sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/70159b741886b0bb10c3c6f77d7a0d0109131320

Reverted:
https://github.com/dart-lang/sdk/commit/5397c5427e9102a8ea7602174be2664d4c15bb8b
Committed:
https://github.com/dart-lang/sdk/commit/37afcd5197bb408a4fbfc76bb8fb521ddbb1ca25
==========

[Johnni Winther, 2016-10-18 12:03:12]

Committed patchset #5 (id:80001) manually as
37afcd5197bb408a4fbfc76bb8fb521ddbb1ca25 (presubmit successful).

[Siggi Cherem (dart-lang), 2016-10-18 14:45:22]

lgtm

https://codereview.chromium.org/2423953002/diff/80001/pkg/compiler/lib/src/un...
File pkg/compiler/lib/src/universe/use.dart (right):

https://codereview.chromium.org/2423953002/diff/80001/pkg/compiler/lib/src/un...
pkg/compiler/lib/src/universe/use.dart:228: return new
StaticUse.internal(element, StaticUseKind.GENERAL);
shouldn't this and the one below be a DIRECT_INVOKE too?

[Johnni Winther, 2016-10-19 07:45:43]

https://codereview.chromium.org/2423953002/diff/80001/pkg/compiler/lib/src/un...
File pkg/compiler/lib/src/universe/use.dart (right):

https://codereview.chromium.org/2423953002/diff/80001/pkg/compiler/lib/src/un...
pkg/compiler/lib/src/universe/use.dart:228: return new
StaticUse.internal(element, StaticUseKind.GENERAL);
On 2016/10/18 14:45:22, Siggi Cherem (dart-lang) wrote:
> shouldn't this and the one below be a DIRECT_INVOKE too?

No. This is only used for getters and fields which cannot (also) be closurized.