Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 2423923002: [crankshaft] Eliminate unnecessary ToNumber call (Closed)

Created:
4 years, 2 months ago by smvv
Modified:
4 years, 2 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[crankshaft] Eliminate unnecessary ToNumber call This is a fix for a regression that started ~6 months ago when https://codereview.chromium.org/1757013002 landed. This patch will remove the unnecessary Change/CallWithDescriptor/Change opcodes causing the regression. BUG=v8:5373 R=bmeurer@chromium.org Committed: https://crrev.com/f87d19c42e12d44b7f836def6b54320b5e8ff999 Cr-Commit-Position: refs/heads/master@{#40345}

Patch Set 1 #

Patch Set 2 : [crankshaft] Eliminate unnecessary ToNumber call #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M AUTHORS View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/crankshaft/hydrogen.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 13 (5 generated)
Benedikt Meurer
lgtm
4 years, 2 months ago (2016-10-17 08:39:34 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2423923002/1
4 years, 2 months ago (2016-10-17 08:41:21 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/26591)
4 years, 2 months ago (2016-10-17 08:52:31 UTC) #5
smvv
On 2016/10/17 at 08:52:31, commit-bot wrote: > Try jobs failed on following builders: > v8_presubmit ...
4 years, 2 months ago (2016-10-17 08:59:13 UTC) #6
smvv
4 years, 2 months ago (2016-10-17 08:59:31 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2423923002/20001
4 years, 2 months ago (2016-10-17 08:59:43 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-17 09:27:26 UTC) #11
commit-bot: I haz the power
4 years, 2 months ago (2016-10-17 09:27:48 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f87d19c42e12d44b7f836def6b54320b5e8ff999
Cr-Commit-Position: refs/heads/master@{#40345}

Powered by Google App Engine
This is Rietveld 408576698