media/renderers/audio_renderer_impl.h - Issue 2423903003: AudioRendererImpl: Don't advance time when rendering stops.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/renderers/audio_renderer_impl.h

Issue 2423903003: AudioRendererImpl: Don't advance time when rendering stops. (Closed)

Patch Set: Doing fix in ARI Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/renderers/audio_renderer_impl.h

diff --git a/media/renderers/audio_renderer_impl.h b/media/renderers/audio_renderer_impl.h

index d76ba06621e94ba6bd0a3a5d2cc39097b5965122..cb50244c666d27486cac576f434651c71c902144 100644

--- a/media/renderers/audio_renderer_impl.h

+++ b/media/renderers/audio_renderer_impl.h

@@ -290,6 +290,9 @@ class MEDIA_EXPORT AudioRendererImpl

// suspend/is suspended and when it resumes.

bool is_suspending_;

+ // Track the last reported media time.

+ base::TimeDelta last_media_time_;

sandersd (OOO until July 31) 2016/10/17 23:37:37 Nit: Suggest |last_reported_media_time_| instead f

chcunningham 2016/10/17 23:49:17 Done.

// End variables which must be accessed under |lock_|. ----------------------

// NOTE: Weak pointers must be invalidated before all other member variables.