tests/lib/mirrors/library_metadata_test.dart - Issue 24239010: Use symbol literals in the mirror tests. (Except for void, the empty string and setters.)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/lib/mirrors/library_metadata_test.dart

Issue 24239010: Use symbol literals in the mirror tests. (Except for void, the empty string and setters.) (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: merge line Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tests/lib/mirrors/library_metadata_test.dart

diff --git a/tests/lib/mirrors/library_metadata_test.dart b/tests/lib/mirrors/library_metadata_test.dart

index 5bb0cec26a646d64de06d5d112438870b23f9107..d6f54a55ef5d12eececd4517fcde16da3263b5bb 100644

--- a/tests/lib/mirrors/library_metadata_test.dart

+++ b/tests/lib/mirrors/library_metadata_test.dart

@@ -11,8 +11,8 @@ import 'metadata_test.dart';

main() {

MirrorSystem mirrors = currentMirrorSystem();

- checkMetadata(mirrors.findLibrary(const Symbol('test.library_metadata_test')).first,

+ checkMetadata(mirrors.findLibrary(#test.library_metadata_test).first,

[string, symbol]);

- checkMetadata(mirrors.findLibrary(const Symbol('test.metadata_test')).first,

+ checkMetadata(mirrors.findLibrary(#test.metadata_test).first,

[]);

}

« no previous file with comments | « tests/lib/mirrors/libraries_test.dart ('k') | tests/lib/mirrors/metadata_constructed_constant_test.dart » ('j') | no next file with comments »