Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1279)

Unified Diff: tests/lib/mirrors/lazy_static_test.dart

Issue 24239010: Use symbol literals in the mirror tests. (Except for void, the empty string and setters.) (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: merge line Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/lib/mirrors/is_odd_test.dart ('k') | tests/lib/mirrors/libraries_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/lib/mirrors/lazy_static_test.dart
diff --git a/tests/lib/mirrors/lazy_static_test.dart b/tests/lib/mirrors/lazy_static_test.dart
index d82316b7ef943a3979660edc2811ae1fba60e24f..6420e8e17f336dd16089eeaa09e1b281b01ae491 100644
--- a/tests/lib/mirrors/lazy_static_test.dart
+++ b/tests/lib/mirrors/lazy_static_test.dart
@@ -19,15 +19,15 @@ class Foo {
void main() {
expect('Variable(s(hello) in s(Foo), static)',
- reflectClass(Foo).members[new Symbol('hello')]);
- var reflectee = reflectClass(Foo).getField(new Symbol('hello')).reflectee;
+ reflectClass(Foo).members[#hello]);
+ var reflectee = reflectClass(Foo).getField(#hello).reflectee;
Expect.stringEquals('a, c', reflectee.keys.join(', '));
// Call the lazy getter twice as different things probably happen in the
// underlying implementation.
- reflectee = reflectClass(Foo).getField(new Symbol('hello')).reflectee;
+ reflectee = reflectClass(Foo).getField(#hello).reflectee;
Expect.stringEquals('a, c', reflectee.keys.join(', '));
var value = 'fisk';
Foo.hello = value;
- reflectee = reflectClass(Foo).getField(new Symbol('hello')).reflectee;
+ reflectee = reflectClass(Foo).getField(#hello).reflectee;
Expect.identical(value, reflectee);
}
« no previous file with comments | « tests/lib/mirrors/is_odd_test.dart ('k') | tests/lib/mirrors/libraries_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698