Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(768)

Unified Diff: tests/lib/mirrors/function_type_mirror_test.dart

Issue 24239010: Use symbol literals in the mirror tests. (Except for void, the empty string and setters.) (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: merge line Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/lib/mirrors/fake_function_test.dart ('k') | tests/lib/mirrors/inherit_field_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/lib/mirrors/function_type_mirror_test.dart
diff --git a/tests/lib/mirrors/function_type_mirror_test.dart b/tests/lib/mirrors/function_type_mirror_test.dart
index 4376c83cf44240e139475be5c6c5cd4dcf31a7d1..f712d737e589ad46b7eeb9ca88d6d22d2c7f08af 100644
--- a/tests/lib/mirrors/function_type_mirror_test.dart
+++ b/tests/lib/mirrors/function_type_mirror_test.dart
@@ -13,11 +13,11 @@ bar(int a) {}
main() {
TypedefMirror tm = reflectClass(FooFunction);
FunctionTypeMirror ftm = tm.referent;
- Expect.equals(const Symbol("void"), ftm.returnType.simpleName);
- Expect.equals(const Symbol("int"), ftm.parameters[0].type.simpleName);
- Expect.equals(const Symbol("double"), ftm.parameters[1].type.simpleName);
+ Expect.equals(const Symbol('void'), ftm.returnType.simpleName);
+ Expect.equals(#int, ftm.parameters[0].type.simpleName);
+ Expect.equals(#double, ftm.parameters[1].type.simpleName);
ClosureMirror cm = reflect(bar);
ftm = cm.type;
- Expect.equals(const Symbol("dynamic"), ftm.returnType.simpleName);
- Expect.equals(const Symbol("int"), ftm.parameters[0].type.simpleName);
+ Expect.equals(#dynamic, ftm.returnType.simpleName);
+ Expect.equals(#int, ftm.parameters[0].type.simpleName);
}
« no previous file with comments | « tests/lib/mirrors/fake_function_test.dart ('k') | tests/lib/mirrors/inherit_field_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698