Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Unified Diff: tests/lib/mirrors/equality_test.dart

Issue 24239010: Use symbol literals in the mirror tests. (Except for void, the empty string and setters.) (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: merge line Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/lib/mirrors/class_mirror_type_variables_test.dart ('k') | tests/lib/mirrors/fake_function_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/lib/mirrors/equality_test.dart
diff --git a/tests/lib/mirrors/equality_test.dart b/tests/lib/mirrors/equality_test.dart
index 1b3b79816ee0687e9437202803769c85691fa0d6..77e724f08adf6fa3277e7ed04cf6963bea8c5de4 100644
--- a/tests/lib/mirrors/equality_test.dart
+++ b/tests/lib/mirrors/equality_test.dart
@@ -99,14 +99,14 @@ main() {
{'currentMirrorSystem().voidType' : currentMirrorSystem().voidType, /// 02: ok
'thisLibrary.functions[#subroutine].returnType' : /// 02: ok
- thisLibrary.functions[const Symbol('subroutine')].returnType}, /// 02: ok
+ thisLibrary.functions[#subroutine].returnType}, /// 02: ok
{'currentMirrorSystem().dynamicType' : currentMirrorSystem().dynamicType,
'thisLibrary.functions[#main].returnType' :
- thisLibrary.functions[const Symbol('main')].returnType},
+ thisLibrary.functions[#main].returnType},
{'reflectClass(A)' : reflectClass(A),
- 'thisLibrary.classes[#A]' : thisLibrary.classes[const Symbol('A')],
+ 'thisLibrary.classes[#A]' : thisLibrary.classes[#A],
'reflect(new A<int>()).type.originalDeclaration' :
reflect(new A<int>()).type.originalDeclaration},
@@ -114,7 +114,7 @@ main() {
'reflect(new A<int>()).type' : reflect(new A<int>()).type}, /// 02: ok
{'reflectClass(B)' : reflectClass(B),
- 'thisLibrary.classes[#B]' : thisLibrary.classes[const Symbol('B')],
+ 'thisLibrary.classes[#B]' : thisLibrary.classes[#B],
'reflect(new B()).type' : reflect(new B()).type},
{'thisLibrary' : thisLibrary,
« no previous file with comments | « tests/lib/mirrors/class_mirror_type_variables_test.dart ('k') | tests/lib/mirrors/fake_function_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698