Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(362)

Issue 2423883002: Move should_eager_compile and is_lazily_parsed to DeclarationScope (Closed)

Created:
4 years, 2 months ago by Toon Verwaest
Modified:
4 years, 2 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Move should_eager_compile and is_lazily_parsed to DeclarationScope BUG=v8:5209 Committed: https://crrev.com/9768ff47e74cf51857af41ab66aae5829677030c Cr-Commit-Position: refs/heads/master@{#40343}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -53 lines) Patch
M src/ast/ast.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ast/scopes.h View 6 chunks +8 lines, -21 lines 0 comments Download
M src/ast/scopes.cc View 9 chunks +38 lines, -31 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Toon Verwaest
ptal
4 years, 2 months ago (2016-10-17 08:09:30 UTC) #2
jochen (gone - plz use gerrit)
lgtm
4 years, 2 months ago (2016-10-17 08:58:00 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2423883002/1
4 years, 2 months ago (2016-10-17 09:02:07 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-17 09:04:28 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-17 09:04:56 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9768ff47e74cf51857af41ab66aae5829677030c
Cr-Commit-Position: refs/heads/master@{#40343}

Powered by Google App Engine
This is Rietveld 408576698