Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 242383003: Linux sandbox test: temporarily allow fork() with threads (Closed)

Created:
6 years, 8 months ago by jln (very slow on Chromium)
Modified:
6 years, 8 months ago
Reviewers:
Mark Seaborn, hamaji
CC:
chromium-reviews, agl, jln+watch_chromium.org
Visibility:
Public.

Description

Linux sandbox test: temporarily allow fork() with threads In sandbox tests, we temporarily allow fork() with threads. BUG=364751 R=hamaji@chromium.org TBR=mseaborn NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=264747

Patch Set 1 #

Patch Set 2 : indent #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -10 lines) Patch
M components/nacl/loader/nonsfi/nonsfi_sandbox_unittest.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download
M sandbox/linux/tests/main.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M sandbox/linux/tests/unit_tests.cc View 2 chunks +19 lines, -10 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
jln (very slow on Chromium)
Does this hack work for you as a temporary thing? I need to run, please ...
6 years, 8 months ago (2014-04-18 01:44:48 UTC) #1
hamaji
LGTM
6 years, 8 months ago (2014-04-18 01:45:38 UTC) #2
jln (very slow on Chromium)
Mark: please send to CQ if you approve, I'm leaving for a few hours.
6 years, 8 months ago (2014-04-18 01:49:13 UTC) #3
hamaji
The CQ bit was checked by hamaji@chromium.org
6 years, 8 months ago (2014-04-18 02:21:03 UTC) #4
hamaji
The CQ bit was unchecked by hamaji@chromium.org
6 years, 8 months ago (2014-04-18 02:21:11 UTC) #5
hamaji
Ah, let's wait for Mark?
6 years, 8 months ago (2014-04-18 02:21:28 UTC) #6
jln (very slow on Chromium)
Mark, I'm TBR-ing you to green the tree.
6 years, 8 months ago (2014-04-18 05:27:54 UTC) #7
jln (very slow on Chromium)
The CQ bit was checked by jln@chromium.org
6 years, 8 months ago (2014-04-18 05:27:59 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jln@chromium.org/242383003/20001
6 years, 8 months ago (2014-04-18 05:28:20 UTC) #9
jln (very slow on Chromium)
6 years, 8 months ago (2014-04-18 05:34:22 UTC) #10
Message was sent while issue was closed. 
Committed patchset #3 manually as r264747 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698