Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(823)

Unified Diff: mash/browser/browser.cc

Issue 2423733002: Remove usage of FOR_EACH_OBSERVER macro in mash/ (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mash/browser/browser.cc
diff --git a/mash/browser/browser.cc b/mash/browser/browser.cc
index 9df2cf6fe6d115ef25b10cb9abb98b67e26152c8..e186682145a7dd21d190ec60760a53c3e58abfde 100644
--- a/mash/browser/browser.cc
+++ b/mash/browser/browser.cc
@@ -205,7 +205,8 @@ class TabStrip : public views::View,
AddObserver(tab);
tabs_.push_back(tab);
tab_container_->AddChildView(tab);
- FOR_EACH_OBSERVER(TabStripObserver, observers_, OnTabAdded(tab));
+ for (auto& observer : observers_)
+ observer.OnTabAdded(tab);
SelectTab(tab);
}
@@ -236,7 +237,8 @@ class TabStrip : public views::View,
SelectTab(tabs_[next_selected_index]);
}
Layout();
- FOR_EACH_OBSERVER(TabStripObserver, observers_, OnTabRemoved(tab));
+ for (auto& observer : observers_)
+ observer.OnTabRemoved(tab);
delete tab;
}
@@ -246,7 +248,8 @@ class TabStrip : public views::View,
auto it = std::find(tabs_.begin(), tabs_.end(), tab);
DCHECK(it != tabs_.end());
selected_index_ = it - tabs_.begin();
- FOR_EACH_OBSERVER(TabStripObserver, observers_, OnTabSelected(tab));
+ for (auto& observer : observers_)
+ observer.OnTabSelected(tab);
}
Tab* selected_tab() {
return selected_index_ != -1 ? tabs_[selected_index_] : nullptr;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698