Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 2423733002: Remove usage of FOR_EACH_OBSERVER macro in mash/ (Closed)

Created:
4 years, 2 months ago by Eric Willigers
Modified:
4 years, 2 months ago
Reviewers:
msw
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove usage of FOR_EACH_OBSERVER macro in mash/ Observer lists now support range-based for loops. BUG=655021 Committed: https://crrev.com/5517050cb3a120f0b98cc46ee4f07dcc4df0a280 Cr-Commit-Position: refs/heads/master@{#425595}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M mash/browser/browser.cc View 3 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Eric Willigers
4 years, 2 months ago (2016-10-15 14:08:18 UTC) #4
msw
lgtm
4 years, 2 months ago (2016-10-16 17:25:25 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2423733002/1
4 years, 2 months ago (2016-10-16 20:27:07 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-16 20:47:31 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-16 20:49:05 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5517050cb3a120f0b98cc46ee4f07dcc4df0a280
Cr-Commit-Position: refs/heads/master@{#425595}

Powered by Google App Engine
This is Rietveld 408576698