[inspector] introduce debug-interface.h

[inspector] introduce debug-interface.h

debug-interface.h contains part of v8-debug.h that is used by src/inspector.

BUG=v8:5510
R=dgozman@chromium.org, yangguo@chromium.org

Committed: https://crrev.com/8bb2cef9c33fbcf66aece41f580b3367c9ca2f2e
Cr-Commit-Position: refs/heads/master@{#40404}

[kozy, 2016-10-16 04:37:24]

Description was changed from

==========
[inspector] [WIP] intermediate debug-interface

BUG=5510
R=dgozman@chromium.org, yangguo@chromium.org
==========

to

==========
[inspector] introduce debug-interface.h

debug-interface.h contains part of v8-debug.h that is used by src/inspector.

BUG=5510
R=dgozman@chromium.org, yangguo@chromium.org
==========

[kozy, 2016-10-16 05:10:44]

Dmitry and Yang, please take a look.

I extracted necessary part for src/inspector. All types and definitions should
be in sync with v8-debug.h.
I can remove v8-debug.h in this patch, migrate debug.cc to types from
debug-interface and migrate cc tests for methods that is used by inspector. Or
we can remove it later.

This patch will unblock my work on migrating our JS scripts to native.

[kozy, 2016-10-17 02:59:56]

The CQ bit was checked by kozyatinskiy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-17 02:59:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-17 03:24:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-17 03:24:40]

Dry run: This issue passed the CQ dry run.

[Yang, 2016-10-17 09:53:25]

lgtm once comment addressed.

https://codereview.chromium.org/2423713003/diff/40001/src/debug/debug-interfa...
File src/debug/debug-interface.cc (right):

https://codereview.chromium.org/2423713003/diff/40001/src/debug/debug-interfa...
src/debug/debug-interface.cc:34: class CallDepthScope {
This and some other parts are duplicates of what's in api.cc. I would like to
avoid that. Could we move these to api.h to share it?

[kozy, 2016-10-17 14:38:07]

thanks, all done.

https://codereview.chromium.org/2423713003/diff/40001/src/debug/debug-interfa...
File src/debug/debug-interface.cc (right):

https://codereview.chromium.org/2423713003/diff/40001/src/debug/debug-interfa...
src/debug/debug-interface.cc:34: class CallDepthScope {
On 2016/10/17 09:53:25, Yang wrote:
> This and some other parts are duplicates of what's in api.cc. I would like to
> avoid that. Could we move these to api.h to share it?

Done.

[kozy, 2016-10-17 14:38:12]

The CQ bit was checked by kozyatinskiy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-17 14:38:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-17 14:41:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-17 14:41:50]

Dry run: Try jobs failed on following builders:
  v8_linux64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/14724)
  v8_linux_arm64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel_ng/build...)

[kozy, 2016-10-17 15:00:53]

The CQ bit was checked by kozyatinskiy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-17 15:00:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-17 15:04:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-17 15:04:12]

Dry run: Try jobs failed on following builders:
  v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...)
  v8_linux64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/14726)
  v8_linux_arm64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel_ng/build...)

[kozy, 2016-10-17 15:17:15]

The CQ bit was checked by kozyatinskiy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-17 15:17:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kozy, 2016-10-17 15:17:25]

Patchset #5 (id:80001) has been deleted

[commit-bot: I haz the power, 2016-10-17 15:52:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-17 15:52:47]

Dry run: This issue passed the CQ dry run.

[kozy, 2016-10-17 16:10:51]

Description was changed from

==========
[inspector] introduce debug-interface.h

debug-interface.h contains part of v8-debug.h that is used by src/inspector.

BUG=5510
R=dgozman@chromium.org, yangguo@chromium.org
==========

to

==========
[inspector] introduce debug-interface.h

debug-interface.h contains part of v8-debug.h that is used by src/inspector.

BUG=v8:5510
R=dgozman@chromium.org, yangguo@chromium.org
==========

[dgozman, 2016-10-17 20:58:43]

I don't know how it is usually done in v8, but maybe debug-interface.cc should
be instead implemented in api.cc? It is kind of an api, and will avoid code
duplication. WDYT?

[kozy, 2016-10-18 00:17:50]

On 2016/10/17 20:58:43, dgozman wrote:
> I don't know how it is usually done in v8, but maybe debug-interface.cc should
> be instead implemented in api.cc? It is kind of an api, and will avoid code
> duplication. WDYT?

I like this idea, moved implementation to api.cc.
Yang, WDYT?

[Yang, 2016-10-18 06:22:56]

On 2016/10/18 00:17:50, kozyatinskiy wrote:
> On 2016/10/17 20:58:43, dgozman wrote:
> > I don't know how it is usually done in v8, but maybe debug-interface.cc
should
> > be instead implemented in api.cc? It is kind of an api, and will avoid code
> > duplication. WDYT?
> 
> I like this idea, moved implementation to api.cc.
> Yang, WDYT?

LGTM. I guess we can keep it in api.cc for now. We can still move when
necessary.

[dgozman, 2016-10-18 14:39:59]

lgtm

[kozy, 2016-10-18 14:41:46]

The CQ bit was checked by kozyatinskiy@chromium.org

[commit-bot: I haz the power, 2016-10-18 14:41:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-18 15:15:02]

Description was changed from

==========
[inspector] introduce debug-interface.h

debug-interface.h contains part of v8-debug.h that is used by src/inspector.

BUG=v8:5510
R=dgozman@chromium.org, yangguo@chromium.org
==========

to

==========
[inspector] introduce debug-interface.h

debug-interface.h contains part of v8-debug.h that is used by src/inspector.

BUG=v8:5510
R=dgozman@chromium.org, yangguo@chromium.org
==========

[commit-bot: I haz the power, 2016-10-18 15:15:05]

Committed patchset #6 (id:120001)

[commit-bot: I haz the power, 2016-10-18 15:15:33]

Description was changed from

==========
[inspector] introduce debug-interface.h

debug-interface.h contains part of v8-debug.h that is used by src/inspector.

BUG=v8:5510
R=dgozman@chromium.org, yangguo@chromium.org
==========

to

==========
[inspector] introduce debug-interface.h

debug-interface.h contains part of v8-debug.h that is used by src/inspector.

BUG=v8:5510
R=dgozman@chromium.org, yangguo@chromium.org

Committed: https://crrev.com/8bb2cef9c33fbcf66aece41f580b3367c9ca2f2e
Cr-Commit-Position: refs/heads/master@{#40404}
==========

[commit-bot: I haz the power, 2016-10-18 15:15:34]

Patchset 6 (id:??) landed as
https://crrev.com/8bb2cef9c33fbcf66aece41f580b3367c9ca2f2e
Cr-Commit-Position: refs/heads/master@{#40404}