Refactor webcrypto unittests.

content/renderer/webcrypto_impl.h

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_RENDERER_WEBCRYPTO_IMPL_H_
 #define CONTENT_RENDERER_WEBCRYPTO_IMPL_H_
 
 #include "base/basictypes.h"
 #include "base/compiler_specific.h"
 #include "base/gtest_prod_util.h"
@@ skipping 23 matching lines @@
       WebKit::WebCryptoResult result);
   virtual void sign(
       const WebKit::WebCryptoAlgorithm& algorithm,
       const WebKit::WebCryptoKey& key,
       const unsigned char* data,
       unsigned data_size,
       WebKit::WebCryptoResult result);
 
  protected:
   FRIEND_TEST_ALL_PREFIXES(WebCryptoImplTest, DigestSampleSets);
   FRIEND_TEST_ALL_PREFIXES(WebCryptoImplTest, HMACSampleSets);

[Ryan Sleevi, 2013/09/24 01:17:11]

nit: these two are no longer needed, are they?

[eroman, 2013/09/24 01:26:41]

They are still needed:
  DigestSampleSets: calls DigestInternal
  HMACSampleSets: calls SignInternal

I considered adding forwarding methods in the fixture base class, but I couldn't
stomach it so left the friend tests.

+  friend class WebCryptoImplTest;
 
   void Init();
 
   bool DigestInternal(
       const WebKit::WebCryptoAlgorithm& algorithm,
       const unsigned char* data,
       unsigned data_size,
       WebKit::WebArrayBuffer* buffer);
   bool ImportKeyInternal(
       WebKit::WebCryptoKeyFormat format,
@@ skipping 10 matching lines @@
       unsigned data_size,
       WebKit::WebArrayBuffer* buffer);
 
  private:
   DISALLOW_COPY_AND_ASSIGN(WebCryptoImpl);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_RENDERER_WEBCRYPTO_IMPL_H_