Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 2423633003: Reland of Implement support for closing mac native notifications (Closed)

Created:
4 years, 2 months ago by Miguel Garcia
Modified:
4 years, 2 months ago
CC:
chromium-reviews, Peter Beverloo, mlamouri+watch-notifications_chromium.org, awdf+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Implement support for closing mac native notifications (patchset #1 id:1 of https://codereview.chromium.org/2418183002/ ) Reason for revert: Revert of the revert, the build failure was not caused by this patch it turns out. Original issue's description: > Revert of Implement support for closing mac native notifications (patchset #7 id:160001 of https://codereview.chromium.org/2390153005/ ) > > Reason for revert: > Broke one of the waterfall builders. > > http://build.chromium.org/p/chromium/builders/Mac/builds/20166/steps/compile/logs/json.output > > Original issue's description: > > Implement support for closing mac native notifications > > > > BUG=571056 > > > > Committed: https://crrev.com/fcfa6816d06cc9e4f1a187ab261f45395a81bffa > > Cr-Commit-Position: refs/heads/master@{#425336} > > TBR=rsesek@chromium.org,peter@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=571056 > > Committed: https://crrev.com/07c9a742ca5aebde54a5d96c6ec7224fc8f67cd8 > Cr-Commit-Position: refs/heads/master@{#425380} TBR=rsesek@chromium.org,peter@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=571056 Committed: https://crrev.com/f0093f3fae3c266cf7c2fc9c47f18f2203940a42 Cr-Commit-Position: refs/heads/master@{#425558}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -102 lines) Patch
M chrome/browser/notifications/notification_platform_bridge_mac.mm View 3 chunks +15 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/notifications/notification_response_builder_mac.mm View 1 chunk +5 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/notifications/notification_response_builder_mac_unittest.mm View 6 chunks +61 lines, -98 lines 0 comments Download
M chrome/browser/ui/cocoa/notifications/notification_service_delegate.mm View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Miguel Garcia
Created Reland of Implement support for closing mac native notifications
4 years, 2 months ago (2016-10-15 08:20:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2423633003/1
4 years, 2 months ago (2016-10-15 08:20:46 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-15 08:21:38 UTC) #5
commit-bot: I haz the power
4 years, 2 months ago (2016-10-15 08:23:15 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f0093f3fae3c266cf7c2fc9c47f18f2203940a42
Cr-Commit-Position: refs/heads/master@{#425558}

Powered by Google App Engine
This is Rietveld 408576698