Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 2423633002: Fix metrics collection when push streams are cancelled by SendRstStreams. (Closed)

Created:
4 years, 2 months ago by Zhongyi Shi
Modified:
4 years, 2 months ago
Reviewers:
Buck, Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix metrics collection when push streams are cancelled by SendRstStreams. When push stream is cancelled with sending reset streams, QuicSession::CloseStreamInner is invoked before QuicChromiumClientSession::CloseStream() which ignores the metrics collection for bytes that has been pushed. BUG=232040 Committed: https://crrev.com/d62d3e8f2f2c3a896e36655f2f2d51936f03deb4 Cr-Commit-Position: refs/heads/master@{#425526}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M net/quic/chromium/quic_chromium_client_session.cc View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Zhongyi Shi
4 years, 2 months ago (2016-10-14 23:22:51 UTC) #2
Buck
lgtm
4 years, 2 months ago (2016-10-14 23:36:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2423633002/1
4 years, 2 months ago (2016-10-14 23:52:03 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-15 01:12:36 UTC) #6
commit-bot: I haz the power
4 years, 2 months ago (2016-10-15 01:14:23 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d62d3e8f2f2c3a896e36655f2f2d51936f03deb4
Cr-Commit-Position: refs/heads/master@{#425526}

Powered by Google App Engine
This is Rietveld 408576698