Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2423593002: Add test directive to include other files used by a test in its compiled output directory. (Closed)

Created:
4 years, 2 months ago by rmacnak
Modified:
4 years, 2 months ago
Reviewers:
Florian Schneider, siva
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add test directive to include other files used by a test in its compiled output directory. Fixes #27591 R=fschneider@google.com Committed: https://github.com/dart-lang/sdk/commit/fe04737a77dc9eab4663c1db2e0760341056e673

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+136 lines, -51 lines) Patch
M tests/standalone/io/file_input_stream_test.dart View 4 chunks +8 lines, -9 lines 0 comments Download
M tests/standalone/io/file_invalid_arguments_test.dart View 7 chunks +8 lines, -9 lines 0 comments Download
A + tests/standalone/io/fixed_length_file View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/standalone/io/fixed_length_file_out View 0 chunks +-1 lines, --1 lines 0 comments Download
M tests/standalone/io/http_proxy_advanced_test.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M tests/standalone/io/http_proxy_test.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M tests/standalone/io/https_bad_certificate_test.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M tests/standalone/io/https_server_test.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M tests/standalone/io/https_unauthorized_test.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M tests/standalone/io/raw_secure_server_closing_test.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M tests/standalone/io/raw_secure_server_socket_test.dart View 1 chunk +5 lines, -0 lines 0 comments Download
M tests/standalone/io/raw_secure_socket_pause_test.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M tests/standalone/io/raw_secure_socket_test.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M tests/standalone/io/read_into_const_list_test.dart View 2 chunks +4 lines, -6 lines 0 comments Download
M tests/standalone/io/regress_21160_test.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M tests/standalone/io/resolve_symbolic_links_test.dart View 1 chunk +2 lines, -1 line 0 comments Download
M tests/standalone/io/secure_bad_certificate_test.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M tests/standalone/io/secure_client_raw_server_test.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M tests/standalone/io/secure_client_server_test.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M tests/standalone/io/secure_multiple_client_server_test.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M tests/standalone/io/secure_server_client_certificate_test.dart View 1 chunk +13 lines, -0 lines 0 comments Download
M tests/standalone/io/secure_server_closing_test.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M tests/standalone/io/secure_server_socket_test.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M tests/standalone/io/secure_session_resume_test.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M tests/standalone/io/secure_socket_alpn_test.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M tests/standalone/io/secure_socket_renegotiate_test.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M tests/standalone/io/secure_socket_test.dart View 1 chunk +6 lines, -0 lines 0 comments Download
M tests/standalone/io/security_context_argument_test.dart View 1 chunk +9 lines, -0 lines 0 comments Download
M tests/standalone/io/socket_upgrade_to_secure_test.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M tests/standalone/io/web_socket_error_test.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/standalone/standalone.status View 1 chunk +0 lines, -28 lines 0 comments Download
M tools/testing/dart/test_suite.dart View 4 chunks +17 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
rmacnak
4 years, 2 months ago (2016-10-14 22:01:14 UTC) #2
Florian Schneider
lgtm
4 years, 2 months ago (2016-10-14 22:38:29 UTC) #3
rmacnak
4 years, 2 months ago (2016-10-14 23:11:30 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
fe04737a77dc9eab4663c1db2e0760341056e673 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698