Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2423563003:
Remove usage of FOR_EACH_OBSERVER macro in media/ (Closed)
|
Created:
4 years, 2 months ago by Eric Willigers Modified:
4 years, 2 months ago CC:
chromium-reviews, feature-media-reviews_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRemove usage of FOR_EACH_OBSERVER macro in media/
Observer lists now support range-based for loops.
BUG=655021
Committed: https://crrev.com/b11c071cc39ba3f1cddf28447f3107cff9f55c25
Cr-Commit-Position: refs/heads/master@{#425830}
Patch Set 1 #
Messages
Total messages: 19 (11 generated)
The CQ bit was checked by ericwilligers@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
ericwilligers@chromium.org changed reviewers: + henrika@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
LGTM but I am not an owner. Sorry.
Description was changed from ========== Remove usage of FOR_EACH_OBSERVER macro in media/ Observer lists now support range-based for loops. BUG=655021 ========== to ========== Remove usage of FOR_EACH_OBSERVER macro in media/ Observer lists now support range-based for loops. BUG=655021 ==========
henrika@chromium.org changed reviewers: + tommi@chromium.org
ericwilligers@chromium.org changed reviewers: + hubbe@chromium.org
lgtm
The CQ bit was checked by ericwilligers@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
Message was sent while issue was closed.
Description was changed from ========== Remove usage of FOR_EACH_OBSERVER macro in media/ Observer lists now support range-based for loops. BUG=655021 ========== to ========== Remove usage of FOR_EACH_OBSERVER macro in media/ Observer lists now support range-based for loops. BUG=655021 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Remove usage of FOR_EACH_OBSERVER macro in media/ Observer lists now support range-based for loops. BUG=655021 ========== to ========== Remove usage of FOR_EACH_OBSERVER macro in media/ Observer lists now support range-based for loops. BUG=655021 Committed: https://crrev.com/b11c071cc39ba3f1cddf28447f3107cff9f55c25 Cr-Commit-Position: refs/heads/master@{#425830} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/b11c071cc39ba3f1cddf28447f3107cff9f55c25 Cr-Commit-Position: refs/heads/master@{#425830} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
