Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1199)

Unified Diff: components/safe_browsing_db/v4_local_database_manager.cc

Issue 2423523003: Small: Add store specific histograms also. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/safe_browsing_db/v4_store.cc » ('j') | tools/metrics/histograms/histograms.xml » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/safe_browsing_db/v4_local_database_manager.cc
diff --git a/components/safe_browsing_db/v4_local_database_manager.cc b/components/safe_browsing_db/v4_local_database_manager.cc
index e489946da80f5a59bf471d97b3392b0571b4b531..dc1b2e169dd0b13765d0eca628f91df6b8380b82 100644
--- a/components/safe_browsing_db/v4_local_database_manager.cc
+++ b/components/safe_browsing_db/v4_local_database_manager.cc
@@ -26,6 +26,8 @@ const ThreatSeverity kLeastSeverity =
std::numeric_limits<ThreatSeverity>::max();
ListInfos GetListInfos() {
+ // NOTE(vakh): When adding a store here, add the corresponding store-specific
+ // histograms also.
Nathan Parker 2016/10/18 04:06:18 Add the name of the histogram(s) group so it's eas
return ListInfos(
{ListInfo(true, "UrlMalware.store", GetUrlMalwareId(),
SB_THREAT_TYPE_URL_MALWARE),
« no previous file with comments | « no previous file | components/safe_browsing_db/v4_store.cc » ('j') | tools/metrics/histograms/histograms.xml » ('J')

Powered by Google App Engine
This is Rietveld 408576698