Small: Add store specific histograms also.

Add store specific histograms also.
This is a follow-up from http://crrev.com/2409793002/#msg40

BUG=651911, 543161
Committed: https://crrev.com/fcf737336cc6c6c2e1589054dc05c0926fe1d54b
Cr-Commit-Position: refs/heads/master@{#426072}

[vakh (use Gerrit instead), 2016-10-15 00:05:55]

The CQ bit was checked by vakh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-15 00:06:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[vakh (use Gerrit instead), 2016-10-15 00:11:03]

vakh@chromium.org changed reviewers:
+ holte@chromium.org, nparker@chromium.org

[vakh (use Gerrit instead), 2016-10-15 00:11:04]

I couldn't have used ordering="prefix", because it adds the specified suffix
after the first period character in the histogram metric name.

Therefore, I've added the histograms manually.

[Steven Holte, 2016-10-15 00:29:16]

histograms lgtm

[commit-bot: I haz the power, 2016-10-15 01:11:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-15 01:11:18]

Dry run: This issue passed the CQ dry run.

[vakh (use Gerrit instead), 2016-10-17 21:13:49]

Ping.
+cc: shess@

[Nathan Parker, 2016-10-18 04:06:18]

https://codereview.chromium.org/2423523003/diff/1/components/safe_browsing_db...
File components/safe_browsing_db/v4_local_database_manager.cc (right):

https://codereview.chromium.org/2423523003/diff/1/components/safe_browsing_db...
components/safe_browsing_db/v4_local_database_manager.cc:30: // histograms also.
Add the name of the histogram(s) group so it's easy to find.

https://codereview.chromium.org/2423523003/diff/1/tools/metrics/histograms/hi...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2423523003/diff/1/tools/metrics/histograms/hi...
tools/metrics/histograms/histograms.xml:51463: +   
name="SafeBrowsing.V4ProcessFullUpdate.ApplyUpdate.UrlMalware.Result"
We really need to use the templating functionality to expand these.  Otherwise,
this CL turns three short strings into 480 lines of mechanical config with
repeated descriptios, and kind of spoils the ease with which we can add a new
store.

holte -- Is there a better way to do this?

If we cannot parameterize the second-to-last dotted-component, how about we
switch up the scheme to put the store name at the end since we can parameterize
that? Then you could define these metrics

SafeBrowsing.V4ProcessFullUpdate.ApplyUpdate.Time
SafeBrowsing.V4ProcessFullUpdate.ApplyUpdate.Result
SafeBrowsing.V4ProcessFullUpdate.DecodeAdditions.Time
SafeBrowsing.V4ProcessFullUpdate.DecodeAdditions.Result
SafeBrowsing.V4ProcessFullUpdate.MergeUpdate.Time
...

And then

<histogram_suffixes name="SafeBrowsingStoreMetrics">
    <suffix name="UrlMalware"/>
    <suffix name="UrlSoceng"/>
    <suffix name="UrlUws"/>
    // Add new stores here.

    <affected-histogram
name="SafeBrowsing.V4ProcessFullUpdate.ApplyUpdate.Time"/>
    <affected-histogram
name="SafeBrowsing.V4ProcessFullUpdate.ApplyUpdate.Result"/>
    ...
 </histogram_suffixes>

That makes it just one line to add a new store.  You could also parameterize the
.Time and .Result metrics which would cut them in half, though that's a bit less
important since we're not likely to add more of those.

[vakh (use Gerrit instead), 2016-10-18 19:55:45]

Use the store name at the end of the histogram to make the XML much simpler

[vakh (use Gerrit instead), 2016-10-18 19:55:46]

The CQ bit was checked by vakh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-18 19:56:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[vakh (use Gerrit instead), 2016-10-18 19:57:53]

Update the comment about histogram naming

[vakh (use Gerrit instead), 2016-10-18 19:57:56]

The CQ bit was checked by vakh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-18 19:58:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-18 21:36:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-18 21:36:46]

Dry run: This issue passed the CQ dry run.

[Nathan Parker, 2016-10-18 22:26:02]

lgtm

nice!

[vakh (use Gerrit instead), 2016-10-18 22:26:24]

The CQ bit was checked by vakh@chromium.org

[vakh (use Gerrit instead), 2016-10-18 22:26:24]

The patchset sent to the CQ was uploaded after l-g-t-m from holte@chromium.org
Link to the patchset: https://codereview.chromium.org/2423523003/#ps40001
(title: "Update the comment about histogram naming")

[commit-bot: I haz the power, 2016-10-18 22:27:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-18 22:38:01]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-10-21 13:04:05]

Description was changed from

==========
Add store specific histograms also.
This is a follow-up from http://crrev.com/2409793002/#msg40

BUG=651911, 543161
==========

to

==========
Add store specific histograms also.
This is a follow-up from http://crrev.com/2409793002/#msg40

BUG=651911, 543161

Committed: https://crrev.com/fcf737336cc6c6c2e1589054dc05c0926fe1d54b
Cr-Commit-Position: refs/heads/master@{#426072}
==========

[commit-bot: I haz the power, 2016-10-21 13:04:06]

Patchset 3 (id:??) landed as
https://crrev.com/fcf737336cc6c6c2e1589054dc05c0926fe1d54b
Cr-Commit-Position: refs/heads/master@{#426072}