add a view for users to explore pub packages

add a view for users to explore pub packages

R=danrubel@google.com

Committed: https://code.google.com/p/dart/source/detail?r=27834

[danrubel, 2013-09-23 18:44:01]

LGTM with suggestions for a future CL

https://codereview.chromium.org/24235011/diff/1/editor/tools/plugins/com.goog...
File
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/pub/PubCacheManager.java
(right):

https://codereview.chromium.org/24235011/diff/1/editor/tools/plugins/com.goog...
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/pub/PubCacheManager.java:57:
pubCachePackages = (HashMap<String, Object>) object;
Change type of object from Map to HashMap so no cast is necessary?

https://codereview.chromium.org/24235011/diff/1/editor/tools/plugins/com.goog...
File
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/pub/PubPackageManager.java
(right):

https://codereview.chromium.org/24235011/diff/1/editor/tools/plugins/com.goog...
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/pub/PubPackageManager.java:44:
public class PubPackageManager {
new PubPackageManagerTest tests for the new listener interface?
Feed simulated pub.dartlang.org output to test processing and listener?

https://codereview.chromium.org/24235011/diff/1/editor/tools/plugins/com.goog...
File
editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/pub/PubCacheManagerTest.java
(right):

https://codereview.chromium.org/24235011/diff/1/editor/tools/plugins/com.goog...
editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/pub/PubCacheManagerTest.java:89:
assertEquals("/Users/keertip/.pub-cache/hosted/pub.dartlang.org/browser-0.5.20",
location);
Will this hardcoded absolute path work  on other machines?

https://codereview.chromium.org/24235011/diff/1/editor/tools/plugins/com.goog...
File
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/pub/AddPackageAction.java
(right):

https://codereview.chromium.org/24235011/diff/1/editor/tools/plugins/com.goog...
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/pub/AddPackageAction.java:95:
if (PubPackageUtils.runPubInstall(newProjectDir, monitor)) {
Inject pub package manager into this class so that it can be tested without
invoking pub?

https://codereview.chromium.org/24235011/diff/1/editor/tools/plugins/com.goog...
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/pub/AddPackageAction.java:107:
String location = PubCacheManager.getInstance().getCacheLocation(packageName,
version);
Inject pub cache manager into this class so that it can be tested without
invoking pub?

https://codereview.chromium.org/24235011/diff/1/editor/tools/plugins/com.goog...
File
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/pub/PubPackageUtils.java
(right):

https://codereview.chromium.org/24235011/diff/1/editor/tools/plugins/com.goog...
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/pub/PubPackageUtils.java:103:
HashMap<String, Object> pubCachePackages =
PubCacheManager.getInstance().updateAndGetAllCachePackages();
Inject pub cache manager so that this can be tested and part of a larger tests?

[keertip, 2013-09-24 15:54:14]

https://codereview.chromium.org/24235011/diff/1/editor/tools/plugins/com.goog...
File
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/pub/PubCacheManager.java
(right):

https://codereview.chromium.org/24235011/diff/1/editor/tools/plugins/com.goog...
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/pub/PubCacheManager.java:57:
pubCachePackages = (HashMap<String, Object>) object;
On 2013/09/23 18:44:02, danrubel wrote:
> Change type of object from Map to HashMap so no cast is necessary?

Done.

https://codereview.chromium.org/24235011/diff/1/editor/tools/plugins/com.goog...
File
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/pub/PubPackageManager.java
(right):

https://codereview.chromium.org/24235011/diff/1/editor/tools/plugins/com.goog...
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/pub/PubPackageManager.java:44:
public class PubPackageManager {
Will add tests in separate cl.

On 2013/09/23 18:44:02, danrubel wrote:
> new PubPackageManagerTest tests for the new listener interface?
> Feed simulated http://pub.dartlang.org output to test processing and listener?

https://codereview.chromium.org/24235011/diff/1/editor/tools/plugins/com.goog...
File
editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/pub/PubCacheManagerTest.java
(right):

https://codereview.chromium.org/24235011/diff/1/editor/tools/plugins/com.goog...
editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/pub/PubCacheManagerTest.java:89:
assertEquals("/Users/keertip/.pub-cache/hosted/pub.dartlang.org/browser-0.5.20",
location);
Yes, have hardcoded the pub cache list for the test CACHE_STRING

On 2013/09/23 18:44:02, danrubel wrote:
> Will this hardcoded absolute path work  on other machines?

https://codereview.chromium.org/24235011/diff/1/editor/tools/plugins/com.goog...
File
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/pub/AddPackageAction.java
(right):

https://codereview.chromium.org/24235011/diff/1/editor/tools/plugins/com.goog...
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/pub/AddPackageAction.java:95:
if (PubPackageUtils.runPubInstall(newProjectDir, monitor)) {
Will do and add tests in subsequent cl.

On 2013/09/23 18:44:02, danrubel wrote:
> Inject pub package manager into this class so that it can be tested without
> invoking pub?

Done.

https://codereview.chromium.org/24235011/diff/1/editor/tools/plugins/com.goog...
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/pub/AddPackageAction.java:107:
String location = PubCacheManager.getInstance().getCacheLocation(packageName,
version);
Will do.

On 2013/09/23 18:44:02, danrubel wrote:
> Inject pub cache manager into this class so that it can be tested without
> invoking pub?

https://codereview.chromium.org/24235011/diff/1/editor/tools/plugins/com.goog...
File
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/pub/PubPackageUtils.java
(right):

https://codereview.chromium.org/24235011/diff/1/editor/tools/plugins/com.goog...
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/pub/PubPackageUtils.java:103:
HashMap<String, Object> pubCachePackages =
PubCacheManager.getInstance().updateAndGetAllCachePackages();
Will do.

On 2013/09/23 18:44:02, danrubel wrote:
> Inject pub cache manager so that this can be tested and part of a larger
tests?

[keertip, 2013-09-24 17:40:13]

Committed patchset #2 manually as r27834 (presubmit successful).