Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Issue 2423463002: Simpler viewportAndroid.css setup for WebFrameTests. (Closed)

Created:
4 years, 2 months ago by rune
Modified:
4 years, 2 months ago
Reviewers:
bokan
CC:
chromium-reviews, blink-reviews, kinuko+watch
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Simpler viewportAndroid.css setup for WebFrameTests. Enable use of viewportAndroid.css by setting WebViewportStyle::Mobile instead of explicitly parsing the sheet as part of the tests. Also corrected some typos. R=bokan@chromium.org Committed: https://crrev.com/81fc04ade2ce07f59bed208a4809b17cb347f62f Cr-Commit-Position: refs/heads/master@{#425355}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -15 lines) Patch
M third_party/WebKit/Source/web/tests/WebFrameTest.cpp View 3 chunks +5 lines, -15 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
rune
ptal
4 years, 2 months ago (2016-10-14 14:41:05 UTC) #2
bokan
Awesome, thanks! lgtm
4 years, 2 months ago (2016-10-14 14:42:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2423463002/1
4 years, 2 months ago (2016-10-14 16:35:36 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-14 16:44:09 UTC) #9
commit-bot: I haz the power
4 years, 2 months ago (2016-10-14 16:47:29 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/81fc04ade2ce07f59bed208a4809b17cb347f62f
Cr-Commit-Position: refs/heads/master@{#425355}

Powered by Google App Engine
This is Rietveld 408576698