chrome/browser/page_load_metrics/page_load_metrics_embedder_interface.h - Issue 2423383002: [Prerender] first contentful paint histograms.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/page_load_metrics/page_load_metrics_embedder_interface.h

Issue 2423383002: [Prerender] first contentful paint histograms. (Closed)

Patch Set: MSVC compilation error Created 3 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc ('k') | chrome/browser/page_load_metrics/page_load_metrics_initialize.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/page_load_metrics/page_load_metrics_embedder_interface.h

diff --git a/chrome/browser/page_load_metrics/page_load_metrics_embedder_interface.h b/chrome/browser/page_load_metrics/page_load_metrics_embedder_interface.h

index 038800d9c59b12dc9e770e27a2bb0fa5f10e42e1..983a0145f03c158485914c621e799bb8c78986df 100644

--- a/chrome/browser/page_load_metrics/page_load_metrics_embedder_interface.h

+++ b/chrome/browser/page_load_metrics/page_load_metrics_embedder_interface.h

@@ -7,10 +7,6 @@

class GURL;

-namespace content {

-class WebContents;

-} // namespace content

namespace page_load_metrics {

class PageLoadTracker;

@@ -20,7 +16,6 @@ class PageLoadTracker;

class PageLoadMetricsEmbedderInterface {

public:

virtual ~PageLoadMetricsEmbedderInterface() {}

- virtual bool IsPrerendering(content::WebContents* web_contents) = 0;

virtual bool IsNewTabPageUrl(const GURL& url) = 0;

virtual void RegisterObservers(PageLoadTracker* metrics) = 0;

};