Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1524)

Unified Diff: chrome/browser/page_load_metrics/observers/no_state_prefetch_page_load_metrics_observer.cc

Issue 2423383002: [Prerender] first contentful paint histograms. (Closed)
Patch Set: Unify with nostate histograms Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/observers/no_state_prefetch_page_load_metrics_observer.cc
diff --git a/chrome/browser/page_load_metrics/observers/no_state_prefetch_page_load_metrics_observer.cc b/chrome/browser/page_load_metrics/observers/no_state_prefetch_page_load_metrics_observer.cc
index a59640ed3d3ab56f9b61401921abd93588460767..d51be960add891c780ebdeb4bb5d4c6593e6d794 100644
--- a/chrome/browser/page_load_metrics/observers/no_state_prefetch_page_load_metrics_observer.cc
+++ b/chrome/browser/page_load_metrics/observers/no_state_prefetch_page_load_metrics_observer.cc
@@ -24,7 +24,7 @@ NoStatePrefetchPageLoadMetricsObserver::CreateIfNeeded(
NoStatePrefetchPageLoadMetricsObserver::NoStatePrefetchPageLoadMetricsObserver(
prerender::PrerenderManager* manager)
- : is_no_store_(false), prerender_manager_(manager) {
+ : is_no_store_(false), was_hidden_(false), prerender_manager_(manager) {
DCHECK(prerender_manager_);
}
@@ -46,6 +46,15 @@ void NoStatePrefetchPageLoadMetricsObserver::OnFirstContentfulPaint(
const page_load_metrics::PageLoadTiming& timing,
const page_load_metrics::PageLoadExtraInfo& extra_info) {
DCHECK(timing.first_contentful_paint.has_value());
- prerender_manager_->RecordFirstContentfulPaint(
- extra_info.start_url, is_no_store_, *timing.first_contentful_paint);
+ prerender_manager_->RecordNoStateFirstContentfulPaint(
+ extra_info.start_url, is_no_store_, was_hidden_,
+ *timing.first_contentful_paint);
+}
+
+page_load_metrics::PageLoadMetricsObserver::ObservePolicy
+NoStatePrefetchPageLoadMetricsObserver::OnHidden(
+ const page_load_metrics::PageLoadTiming& timing,
+ const page_load_metrics::PageLoadExtraInfo& extra_info) {
+ was_hidden_ = true;
+ return CONTINUE_OBSERVING;
}

Powered by Google App Engine
This is Rietveld 408576698