Chromium Code Reviews| Index: chrome/browser/page_load_metrics/metrics_web_contents_observer_unittest.cc |
| diff --git a/chrome/browser/page_load_metrics/metrics_web_contents_observer_unittest.cc b/chrome/browser/page_load_metrics/metrics_web_contents_observer_unittest.cc |
| index ee45eed251f7db03ac7562022a2bad58ab1b6282..a9d054411143fb76876a6ed721146e5017954de4 100644 |
| --- a/chrome/browser/page_load_metrics/metrics_web_contents_observer_unittest.cc |
| +++ b/chrome/browser/page_load_metrics/metrics_web_contents_observer_unittest.cc |
| @@ -109,16 +109,9 @@ class FilteringPageLoadMetricsObserver : public PageLoadMetricsObserver { |
| class TestPageLoadMetricsEmbedderInterface |
| : public PageLoadMetricsEmbedderInterface { |
| public: |
| - TestPageLoadMetricsEmbedderInterface() |
| - : is_prerendering_(false), is_ntp_(false) {} |
| + TestPageLoadMetricsEmbedderInterface() : is_ntp_(false) {} |
| - bool IsPrerendering(content::WebContents* web_contents) override { |
| - return is_prerendering_; |
| - } |
| bool IsNewTabPageUrl(const GURL& url) override { return is_ntp_; } |
| - void set_is_prerendering(bool is_prerendering) { |
| - is_prerendering_ = is_prerendering; |
| - } |
| void set_is_ntp(bool is_ntp) { is_ntp_ = is_ntp; } |
| void RegisterObservers(PageLoadTracker* tracker) override { |
| tracker->AddObserver(base::MakeUnique<TestPageLoadMetricsObserver>( |
| @@ -148,7 +141,6 @@ class TestPageLoadMetricsEmbedderInterface |
| std::vector<PageLoadTiming> complete_timings_; |
| std::vector<GURL> observed_committed_urls_; |
| std::vector<GURL> completed_filtered_urls_; |
| - bool is_prerendering_; |
| bool is_ntp_; |
| }; |
| @@ -322,23 +314,6 @@ TEST_F(MetricsWebContentsObserverTest, SamePageNoTrigger) { |
| CheckNoErrorEvents(); |
| } |
| -TEST_F(MetricsWebContentsObserverTest, DontLogPrerender) { |
|
Charlie Harrison
2016/11/21 14:30:17
It would be nice if we could keep a test like this
|
| - PageLoadTiming timing; |
| - timing.navigation_start = base::Time::FromDoubleT(1); |
| - |
| - content::WebContentsTester* web_contents_tester = |
| - content::WebContentsTester::For(web_contents()); |
| - embedder_interface_->set_is_prerendering(true); |
| - observer_->WasHidden(); |
| - |
| - web_contents_tester->NavigateAndCommit(GURL(kDefaultTestUrl)); |
| - SimulateTimingUpdate(timing); |
| - web_contents_tester->NavigateAndCommit(GURL(kDefaultTestUrl2)); |
| - ASSERT_EQ(0, CountUpdatedTimingReported()); |
| - ASSERT_EQ(0, CountCompleteTimingReported()); |
| - CheckNoErrorEvents(); |
| -} |
| - |
| TEST_F(MetricsWebContentsObserverTest, DontLogNewTabPage) { |
| PageLoadTiming timing; |
| timing.navigation_start = base::Time::FromDoubleT(1); |