chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc - Issue 2423383002: [Prerender] first contentful paint histograms.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc

Issue 2423383002: [Prerender] first contentful paint histograms. (Closed)

Patch Set: Generalize internal histogram function name Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/page_load_metrics/observers/no_state_prefetch_page_load_metrics_observer.cc ('k') | chrome/browser/page_load_metrics/observers/prerender_page_load_metrics_observer.h » ('j') | chrome/browser/page_load_metrics/observers/prerender_page_load_metrics_observer.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc

diff --git a/chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc b/chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc

index fba85610333a4622eccb2bffa6837b946a745bd2..9a87792b8ad8032c1fc491d0db18d7bfbedf2933 100644

--- a/chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc

+++ b/chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc

@@ -26,10 +26,6 @@ class TestPageLoadMetricsEmbedderInterface

PageLoadMetricsObserverTestHarness* test)

: test_(test) {}

- bool IsPrerendering(content::WebContents* web_contents) override {

- return false;

- }

bool IsNewTabPageUrl(const GURL& url) override { return false; }

// Forward the registration logic to the test class so that derived classes