chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc - Issue 2423383002: [Prerender] first contentful paint histograms.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc

Issue 2423383002: [Prerender] first contentful paint histograms. (Closed)

Patch Set: comments Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/page_load_metrics/observers/prerender_page_load_metrics_observer.cc ('K') | « chrome/browser/page_load_metrics/observers/prerender_page_load_metrics_observer.cc ('k') | chrome/browser/page_load_metrics/page_load_metrics_embedder_interface.h » ('j') | chrome/browser/prerender/prerender_browsertest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc

diff --git a/chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc b/chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc

index e1d4d0851db841d51c57f99f5d644e24ff8a7f06..0964200b29ae8621fdebfca21e167724d4462acb 100644

--- a/chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc

+++ b/chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc

@@ -510,12 +510,14 @@ IN_PROC_BROWSER_TEST_F(PageLoadMetricsBrowserTest,

NavigateToUntrackedUrl();

histogram_tester_.ExpectTotalCount(

- prerender::PrerenderHistograms::GetFirstContentfulPaintHistogramName(

- prerender::ORIGIN_NONE, false, true, base::TimeDelta()),

+ prerender::PrerenderHistograms::

+ GetNoStateFirstContentfulPaintHistogramName(

+ prerender::ORIGIN_NONE, false, true, base::TimeDelta()),

0);

histogram_tester_.ExpectTotalCount(

- prerender::PrerenderHistograms::GetFirstContentfulPaintHistogramName(

- prerender::ORIGIN_NONE, false, false, base::TimeDelta()),

+ prerender::PrerenderHistograms::

+ GetNoStateFirstContentfulPaintHistogramName(

+ prerender::ORIGIN_NONE, false, false, base::TimeDelta()),

1);

}

@@ -528,11 +530,13 @@ IN_PROC_BROWSER_TEST_F(PageLoadMetricsBrowserTest,

NavigateToUntrackedUrl();

histogram_tester_.ExpectTotalCount(

- prerender::PrerenderHistograms::GetFirstContentfulPaintHistogramName(

- prerender::ORIGIN_NONE, false, true, base::TimeDelta()),

+ prerender::PrerenderHistograms::

+ GetNoStateFirstContentfulPaintHistogramName(

+ prerender::ORIGIN_NONE, false, true, base::TimeDelta()),

1);

histogram_tester_.ExpectTotalCount(

- prerender::PrerenderHistograms::GetFirstContentfulPaintHistogramName(

- prerender::ORIGIN_NONE, false, false, base::TimeDelta()),

+ prerender::PrerenderHistograms::

+ GetNoStateFirstContentfulPaintHistogramName(

+ prerender::ORIGIN_NONE, false, false, base::TimeDelta()),

0);

}