Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Side by Side Diff: chrome/browser/page_load_metrics/observers/prerender_page_load_metrics_observer.cc

Issue 2423383002: [Prerender] first contentful paint histograms. (Closed)
Patch Set: Unify with nostate histograms Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "chrome/browser/page_load_metrics/observers/prerender_page_load_metrics _observer.h"
6
droger 2016/11/29 15:54:39 #include "base/logging.h" for the DCHECK
mattcary 2016/11/29 16:39:44 Done.
7 #include "base/memory/ptr_util.h"
8 #include "chrome/browser/prerender/prerender_manager.h"
9 #include "chrome/browser/prerender/prerender_manager_factory.h"
10 #include "content/public/browser/web_contents.h"
11 #include "net/http/http_response_headers.h"
12
13 // static
14 std::unique_ptr<page_load_metrics::PageLoadMetricsObserver>
15 PrerenderPageLoadMetricsObserver::CreateIfNeeded(
16 content::WebContents* web_contents) {
17 prerender::PrerenderManager* manager =
18 prerender::PrerenderManagerFactory::GetForBrowserContext(
19 web_contents->GetBrowserContext());
20 if (!manager)
21 return nullptr;
22
23 if (manager->PageLoadMetricsObserverDisabledForTesting())
24 return nullptr;
25
26 return base::WrapUnique<page_load_metrics::PageLoadMetricsObserver>(
droger 2016/11/29 15:54:39 Nit: I think MakeUnique is recommended over WrapUn
mattcary 2016/11/29 16:39:44 I thought you needed to do this to change the type
27 new PrerenderPageLoadMetricsObserver(manager, web_contents));
28 }
29
30 PrerenderPageLoadMetricsObserver::PrerenderPageLoadMetricsObserver(
31 prerender::PrerenderManager* manager,
32 content::WebContents* web_contents)
33 : prerender_manager_(manager),
34 web_contents_(web_contents),
35 is_no_store_(false),
36 was_hidden_(false) {
37 DCHECK(prerender_manager_);
droger 2016/11/29 15:54:39 DCHECK(web_contents_) as well?
mattcary 2016/11/29 16:39:44 Done.
38 }
39
40 page_load_metrics::PageLoadMetricsObserver::ObservePolicy
41 PrerenderPageLoadMetricsObserver::OnStart(
42 content::NavigationHandle* navigation_handle,
43 const GURL& currently_committed_url,
44 bool started_in_foreground) {
45 DCHECK(!started_in_foreground);
46
47 start_ticks_ = navigation_handle->NavigationStart();
48 return CONTINUE_OBSERVING;
49 }
50
51 page_load_metrics::PageLoadMetricsObserver::ObservePolicy
52 PrerenderPageLoadMetricsObserver::OnCommit(
53 content::NavigationHandle* navigation_handle) {
54 const net::HttpResponseHeaders* response_headers =
55 navigation_handle->GetResponseHeaders();
56
57 is_no_store_ = response_headers &&
58 response_headers->HasHeaderValue("cache-control", "no-store");
59 return CONTINUE_OBSERVING;
60 }
61
62 void PrerenderPageLoadMetricsObserver::OnFirstContentfulPaint(
63 const page_load_metrics::PageLoadTiming& timing,
64 const page_load_metrics::PageLoadExtraInfo& extra_info) {
65 DCHECK(!start_ticks_.is_null());
66 prerender_manager_->RecordPrerenderFirstContentfulPaint(
67 extra_info.start_url, web_contents_, is_no_store_, was_hidden_,
68 start_ticks_ + *timing.first_contentful_paint);
69 }
70
71 page_load_metrics::PageLoadMetricsObserver::ObservePolicy
72 PrerenderPageLoadMetricsObserver::OnHidden(
73 const page_load_metrics::PageLoadTiming& timing,
74 const page_load_metrics::PageLoadExtraInfo& extra_info) {
75 was_hidden_ = true;
76 return CONTINUE_OBSERVING;
77 }
78
79 void PrerenderPageLoadMetricsObserver::SetNavigationStartTicksForTesting(
80 base::TimeTicks ticks) {
81 start_ticks_ = ticks;
82 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698